Aw: BluezQt GATT client API

Hi,   the GATT client API is not fully implemented (nor tested). Unfortunately, i do not plan to implement this soon.   However, Qt also provides a BluettothLE API which should work just fine (in client mode).   Best regards, Manuel Weichselbaumer   Gesendet: Freitag, 23. August 2019 um

D22107: Add MediaTransport API

mweichselbaumer closed this revision. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D22107 To: mweichselbaumer, drosca Cc: ltoscano, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22107: Add MediaTransport API

mweichselbaumer added inline comments. INLINE COMMENTS > drosca wrote in tpendingcall.h:45 > Alright, that makes sense. > > With KF6 we can convert all PendingCalls to this form. It would be a good > idea to add `TODO: KF6` somewhere to not forget it. Ok, i will update this patch and land it

D22107: Add MediaTransport API

mweichselbaumer added inline comments. INLINE COMMENTS > ltoscano wrote in a2dp-codecs.h:33 > Will it work with older versions of bluez? Bluez just defines this constant, but does not use it internally (nor we do). So, yes, this works with any version of bluez. REPOSITORY R269 BluezQt

D22107: Add MediaTransport API

mweichselbaumer marked an inline comment as done. mweichselbaumer added inline comments. INLINE COMMENTS > drosca wrote in a2dp-codecs.h:33 > Are you sure about this? Yes, this has also been fixed by bluez as of 2018-12-28. > drosca wrote in tpendingcall.h:45 > Is this really needed? In the

D22107: Add MediaTransport API

mweichselbaumer added a reviewer: drosca. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D22107 To: mweichselbaumer, drosca Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22107: Add MediaTransport API

mweichselbaumer created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mweichselbaumer requested review of this revision. REPOSITORY R269 BluezQt BRANCH mediatransport REVISION DETAIL https://phabricator.kde.org/D22107 AFFECTED FILES

D21584: Add LE Advertising and GATT APIs

mweichselbaumer closed this revision. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D21584 To: mweichselbaumer, drosca Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21584: Add LE Advertising and GATT APIs

mweichselbaumer updated this revision to Diff 59349. mweichselbaumer added a comment. Fixed according to comments REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21584?vs=59346=59349 BRANCH ble_gatt REVISION DETAIL https://phabricator.kde.org/D21584

D21584: Add LE Advertising and GATT APIs

mweichselbaumer updated this revision to Diff 59346. mweichselbaumer added a comment. Fixed according to comments REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21584?vs=59277=59346 BRANCH ble_gatt REVISION DETAIL https://phabricator.kde.org/D21584

D21584: Add LE Advertising and GATT APIs

mweichselbaumer marked an inline comment as done. mweichselbaumer added inline comments. INLINE COMMENTS > drosca wrote in objectmanager.h:47 > I don't really like this class at all. This is implementation detail, and is > of no use for the users of the library, so it shouldn't be exported. On

D21584: Add LE Advertising and GATT APIs

mweichselbaumer added inline comments. INLINE COMMENTS > drosca wrote in gattapplication.h:66 > Should this be made private (preferrably in GattApplicationPrivate)? I override this in test class, so kept as protected. REPOSITORY R269 BluezQt REVISION DETAIL

D21584: Add LE Advertising and GATT APIs

mweichselbaumer updated this revision to Diff 59277. mweichselbaumer added a comment. Fixed according to comments REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21584?vs=59238=59277 BRANCH ble_gatt REVISION DETAIL https://phabricator.kde.org/D21584

D21584: Add LE Advertising and GATT APIs

mweichselbaumer updated this revision to Diff 59238. mweichselbaumer added a comment. Fixed according to comments CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21584?vs=59237=59238 BRANCH ble_gatt REVISION DETAIL https://phabricator.kde.org/D21584 AFFECTED FILES

D21584: Add LE Advertising and GATT APIs

mweichselbaumer updated this revision to Diff 59237. mweichselbaumer added a comment. Fixed according to comments CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21584?vs=59236=59237 BRANCH ble_gatt REVISION DETAIL https://phabricator.kde.org/D21584 AFFECTED FILES

D21584: Add LE Advertising and GATT APIs

mweichselbaumer updated this revision to Diff 59236. mweichselbaumer marked an inline comment as done. mweichselbaumer added a comment. Fixed according to comments CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21584?vs=59151=59236 BRANCH ble_gatt REVISION DETAIL

D21584: Add LE Advertising and GATT APIs

mweichselbaumer marked 11 inline comments as done. mweichselbaumer added inline comments. INLINE COMMENTS > drosca wrote in gattapplication_p.cpp:31 > Shouldn't the caller be made responsible for choosing object path? > If we force a path then we should use "our" namespace -

D21584: Add LE Advertising and GATT APIs

mweichselbaumer added a reviewer: drosca. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D21584 To: mweichselbaumer, drosca Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21584: Add LE Advertising and GATT APIs

mweichselbaumer created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mweichselbaumer requested review of this revision. REPOSITORY R269 BluezQt BRANCH ble_gatt REVISION DETAIL https://phabricator.kde.org/D21584 AFFECTED FILES

D21265: Add Bluez API to DBus XML parser/generator

This revision was automatically updated to reflect the committed changes. Closed by commit R269:bfe94dface00: Add Bluez API to DBus XML parser/generator (authored by mweichselbaumer). Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. REPOSITORY R269 BluezQt

D16084: Add Media and MediaEndpoint API header generation

mweichselbaumer created this revision. mweichselbaumer added a reviewer: drosca. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mweichselbaumer requested review of this revision. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D16084

D15745: Implement Media and MediaEndpoint API

mweichselbaumer added a comment. In D15745#336711 <https://phabricator.kde.org/D15745#336711>, @drosca wrote: > Thanks. > I'll need your full name + e-mail if you don't have dev account to push it. You're welcome. It's been a pleasure to contribute to this l

D15745: Implement Media and MediaEndpoint API

mweichselbaumer updated this revision to Diff 42877. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15745?vs=42861=42877 REVISION DETAIL https://phabricator.kde.org/D15745 AFFECTED FILES autotests/CMakeLists.txt autotests/fakebluez/CMakeLists.txt

D15745: Implement Media and MediaEndpoint API

mweichselbaumer added a comment. In D15745#336644 , @drosca wrote: > Remove NoInputNoOutputAgent and it's good to go. Agree. Is it ok to move it to mediaendpointconnector? REVISION DETAIL https://phabricator.kde.org/D15745 To:

D15745: Implement Media and MediaEndpoint API

mweichselbaumer added a comment. In D15745#336593 , @drosca wrote: > Alright, last thing: > > Why NoInputNoOutputAgent? That should be implemented by the application, and not be part of library. In almost all cases you actually want to

D15745: Implement Media and MediaEndpoint API

mweichselbaumer updated this revision to Diff 42861. mweichselbaumer added a comment. Fixed style issues and smart pointer construction CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15745?vs=42813=42861 REVISION DETAIL https://phabricator.kde.org/D15745 AFFECTED FILES

D15745: Implement Media and MediaEndpoint API

mweichselbaumer marked 3 inline comments as done and an inline comment as not done. REVISION DETAIL https://phabricator.kde.org/D15745 To: mweichselbaumer, drosca Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15745: Implement Media and MediaEndpoint API

mweichselbaumer updated this revision to Diff 42813. mweichselbaumer added a comment. Added autotests and additional test: mediaendpointconnector CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15745?vs=42313=42813 REVISION DETAIL https://phabricator.kde.org/D15745 AFFECTED FILES

D15745: Implement Media and MediaEndpoint API

mweichselbaumer edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D15745 To: mweichselbaumer, drosca Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15745: Implement Media and MediaEndpoint API

mweichselbaumer updated this revision to Diff 42313. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15745?vs=42300=42313 REVISION DETAIL https://phabricator.kde.org/D15745 AFFECTED FILES src/CMakeLists.txt src/a2dp-codecs.h src/interfaces/org.bluez.Media1.xml

D15745: Implement Media and MediaEndpoint API

mweichselbaumer marked 5 inline comments as done. mweichselbaumer added inline comments. INLINE COMMENTS > broulik wrote in media_p.h:37 > Any particular reason this class must inherit `QObject`, you don't seem to be > using `signal` or `slot` in it MediaPrivate will later act as parent for

D15745: Implement Media and MediaEndpoint API

mweichselbaumer created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mweichselbaumer requested review of this revision. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D15745 AFFECTED FILES src/CMakeLists.txt