madcatx marked an inline comment as done.
REPOSITORY
R292 KUnitConversion
REVISION DETAIL
https://phabricator.kde.org/D20284
To: madcatx, broulik, #frameworks, aacid
Cc: apol, aacid, meven, kde-frameworks-devel, michaelh, ngraham, bruns
madcatx marked 2 inline comments as done.
madcatx added inline comments.
INLINE COMMENTS
> aacid wrote in fuel_efficiency.cpp:36
> I understand what you mean here, but i don't think that reciprocal is the
> word that describes this (are you a native speaker? if so maybe it's juts
> that my engl
madcatx updated this revision to Diff 56203.
madcatx added a comment.
More obvious explanation of the meaning of `m_isReciprocal`
REPOSITORY
R292 KUnitConversion
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20284?vs=56201&id=56203
REVISION DETAIL
https://phabricator.kde.org/D
madcatx updated this revision to Diff 56201.
madcatx added a comment.
Added an inverse test with initial value in MPG
REPOSITORY
R292 KUnitConversion
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20284?vs=55574&id=56201
REVISION DETAIL
https://phabricator.kde.org/D20284
AFFEC
madcatx marked an inline comment as done.
REPOSITORY
R292 KUnitConversion
REVISION DETAIL
https://phabricator.kde.org/D20284
To: madcatx, broulik, #frameworks, aacid
Cc: apol, aacid, meven, kde-frameworks-devel, michaelh, ngraham, bruns
madcatx added inline comments.
INLINE COMMENTS
> apol wrote in fuel_efficiency.cpp:36
> I'm not sure I understand what isReciprocal means here.
l/100 km (amount of fuel needed to cross a given distance) is reciprocal to MPG
(distance crossed with a given amount of fuel). KUnitConverter can only
madcatx updated this revision to Diff 55574.
madcatx added a comment.
1. Tweaked conversion factor to match those used by Google online converter
2. Added test to convert l/100 km to other representations and back
REPOSITORY
R292 KUnitConversion
CHANGES SINCE LAST UPDATE
https://phabric
madcatx updated this revision to Diff 55512.
madcatx added a comment.
Tabs vs spaces
REPOSITORY
R292 KUnitConversion
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20284?vs=55511&id=55512
REVISION DETAIL
https://phabricator.kde.org/D20284
AFFECTED FILES
src/fuel_efficiency.c
madcatx created this revision.
madcatx added a reviewer: broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
madcatx requested review of this revision.
REVISION SUMMARY
Previous code (probably) worked only for l/100 km -> MPG but not the other
way aroun
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:a26de31a5dfb: Distinguish between file and directory
delete request in debug output. (authored by madcatx).
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15873?
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:75ee4dfb4042: Add a specific error string for ENOTEMPTY
return code. (authored by madcatx).
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15871?vs=42807&id=4311
madcatx updated this revision to Diff 42807.
madcatx added a comment.
Changed the KIO error code from ERR_INTERNAL to more specific
ERR_CANNOT_RMDIR.
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15871?vs=42645&id=42807
REVISION DETAIL
https://phabr
madcatx added a comment.
Ah, sorry, apparently there is ERR_CANNOT_RMDIR and ERR_COULD_NOT_RMDIR which
translate to the same value with the latter being deprecated. I'll update the
patch to use ERR_CANNOT_RMDIR.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D158
madcatx added a comment.
Well, this
(https://api.kde.org/frameworks/kio/html/deprecated.html#_deprecated15)
marks KIO::ERR_COULD_NOT_RMDIR as deprecated. Is there an alternative I should
use instead?
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D15871
To:
madcatx added a comment.
@elvisangelaccio: OK, what do I have to do?
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D15873
To: madcatx, elvisangelaccio, broulik
Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun,
navarromorales, firef, ngraham, andr
madcatx created this revision.
madcatx added a reviewer: elvisangelaccio.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
madcatx requested review of this revision.
REVISION SUMMARY
This has proven to be useful while I was tracking down what
madcatx created this revision.
madcatx added a reviewer: elvisangelaccio.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
madcatx requested review of this revision.
REVISION SUMMARY
ENOEMPTY return code may be a valid return code from i.e. s
madcatx added a comment.
What is the status on upstreaming this? Is there anything else you need from
me to finish this off?
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D8387
To: madcatx, ngraham, davidedmundson, elvisangelaccio, #frameworks
Cc: cfeck, rdieter
madcatx added inline comments.
INLINE COMMENTS
> cfeck wrote in kio_smb_browse.cpp:521
> While it does no harm, you do not need 'const' for plain types, such as 'int'.
Don't worry, I'm well aware. I however like to use consts wherever possible to
make it clear that changing a value of such vari
madcatx added a comment.
In https://phabricator.kde.org/D8387#157778, @ngraham wrote:
> Do you have commit access? If not, I'll be happy to commit this once some
more of the folks who have made comments have also signed off on a final
version.
No I don't. elvisangelaccio already
madcatx marked 10 inline comments as done.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D8387
To: madcatx, ngraham, davidedmundson, elvisangelaccio, #frameworks
Cc: rdieter, graesslin, z3ntu
madcatx updated this revision to Diff 21049.
madcatx added a comment.
- Check against a range of affected versions
- Small stylistic changes
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8387?vs=21044&id=21049
REVISION DETAIL
https://phabricator.kd
madcatx added inline comments.
INLINE COMMENTS
> elvisangelaccio wrote in kio_smb_browse.cpp:521
> Don't we set `m_enableEEXISTWorkaround` in the constructor?
Yes. The idea is this: When the slave loads, it checks what libsmbclient lib is
available and sets the `m_enableEEXISTWorkaround` if a b
madcatx added inline comments.
INLINE COMMENTS
> elvisangelaccio wrote in kio_smb.cpp:67
> While at it, I'd move `m_openFd` on its own line
It kind of violates my "change only as much as is needed" but the whole kio-smb
source could probably use thorough reformatting anyway. Will do.
> elvisan
madcatx updated this revision to Diff 21044.
madcatx added a comment.
Tabs/spaces issue
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8387?vs=21040&id=21044
REVISION DETAIL
https://phabricator.kde.org/D8387
AFFECTED FILES
smb/kio_smb.cpp
smb/kio
madcatx updated this revision to Diff 21040.
madcatx edited the summary of this revision.
madcatx added a comment.
Detect versions of libsmbclient libraries that are considered broken and
apply the workaround only for those.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8387?vs=210
madcatx added a comment.
In https://phabricator.kde.org/D8387#157502, @ngraham wrote:
> So am I correct that this patch does the following:
>
> - If you go to a real password-protected samba server, without this patch
you are totally screwed; with it, you are correctly offered a chanc
27 matches
Mail list logo
