D19641: Improve pixel grid alignment of go-up/down/next/previous/jump

2019-03-09 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY These icons had subtle alignment issues. They weren't even always visible, but it's a probl

D19639: Change go-up/down-search symlinks target to go-up/down

2019-03-09 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY go-up/down is more appropriate because go-top/bottom is supposed to be for skipping to the

D19633: Improve consistency of window-* and add more

2019-03-09 Thread Noah Davis
ndavis added a comment. In D19633#427913 , @ngraham wrote: > Neat! Very helpful, thanks. > > While you're at it, do you think you could add a `window-unpin` icon too? https://bugs.kde.org/show_bug.cgi?id=405195 Yes, but I'm not sure i

D19638: Make go-bottom/first/last/top look more like media-skip*

2019-03-09 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19638 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19638: Make go-bottom/first/last/top look more like media-skip*

2019-03-09 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Once D19575 lands, the style of `go-top` will conflict

D19575: Add collapse-all and expand-all action icons

2019-03-09 Thread Noah Davis
ndavis requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19575 To: trickyricky26, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19575: Add collapse-all and expand-all action icons

2019-03-09 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Could you align the top of the down arrow in expand-all to the pixel grid and move it down by 1px? Like so: F6677924: Screenshot_20190309_114706.png

D19633: Improve consistency of window-* and add more

2019-03-09 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19633 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19633: Improve consistency of window-* and add more

2019-03-09 Thread Noah Davis
ndavis updated this revision to Diff 53516. ndavis edited the test plan for this revision. ndavis added a comment. Rename window-maximized to window-restore for better 3rd party compatibility REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19633?vs=5351

D19633: Improve consistency of window-* and add more

2019-03-09 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19633 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19633: Improve consistency of window-* and add more

2019-03-09 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Add window-keep-above/below Add window-maximize/maximized/minimize Change window-p

D19629: Change media-skip* and media-seek* style

2019-03-09 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:581ce275edbd: Change media-skip* and media-seek* style (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19629?vs=53494&id=53510 REVISION D

D19629: Change media-skip* and media-seek* style

2019-03-08 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19629 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19629: Change media-skip* and media-seek* style

2019-03-08 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19629 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19629: Change media-skip* and media-seek* style

2019-03-08 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19629 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19629: Change media-skip* and media-seek* style

2019-03-08 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Make media-skip* look more like standard skip forward/back symbols Make media-seek* mor

D19620: Use a searchbar similar to the one in okular

2019-03-08 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Yes, I think this is better and it's good to be consistent. REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, nda

D19575: Add collapse-all and expand-all action icons

2019-03-08 Thread Noah Davis
ndavis added a comment. Use these, they're more similar to the titlebar shade button, but aligned to the pixel grid better. I will change the `go-*` icons in another patch. F6674647: collapse-all16.svg F6674648: collapse-all22.svg

D19575: Add collapse-all and expand-all action icons

2019-03-07 Thread Noah Davis
ndavis added a comment. I just noticed, there is already a `go-top` icon that looks just like `collapse-all`. That's a problem. "Collapse all" is different enough from "Go to top" that they shouldn't be the same icon. I do think that the arrow with the bar on top is more appropriate for

D19575: Add collapse-all and expand-all action icons

2019-03-07 Thread Noah Davis
ndavis requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19575 To: trickyricky26, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19575: Add collapse-all and expand-all action icons

2019-03-07 Thread Noah Davis
ndavis added a comment. The symlinks in the symbolic folder should end with `-symbolic` REPOSITORY R266 Breeze Icons BRANCH collapse-expand-all-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D19575 To: trickyricky26, #vdg, ngraham Cc: ndavis, ngraham, kde-fra

D19575: Add collapse-all and expand-all action icons

2019-03-07 Thread Noah Davis
ndavis added a comment. In D19575#426762 , @ngraham wrote: > Could we get symlinks for these that point to `window-keep-above` and `window-keep-below` too? Ink KWin, the keep above and keep below icons are different. These are the shade/

D19324: Add code-oss icon

2019-02-28 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:54a20776ffb4: Add code-oss icon (authored by axionl, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19324?vs=52826&id=52827 REVISION DET

D19324: Add code-oss icon

2019-02-27 Thread Noah Davis
ndavis added a comment. One last thing, you need to use your real name as your Git user name in order for this patch to pass an automated audit. This page explain how to do that if you need a guide: https://help.github.com/en/articles/setting-your-username-in-git REPOSITORY R266 Breez

D19324: Add code-oss icon

2019-02-27 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. In D19324#421552 , @axionl wrote: > This is my first time to contribute plasma/kde project, I feel sorry for my mistakes and thanks for your h

D19324: Add code-oss icon

2019-02-27 Thread Noah Davis
ndavis added a comment. Great. Now you just need to get rid of the invisible rectangle. You can do that quickly with `sed -i 's|||' code.svg`. After you've done that, I can accept and land this. BTW, you're meant to put the comment for the diff update at the top, but it's not a huge dea

D19324: Add code-oss icon

2019-02-27 Thread Noah Davis
ndavis added a comment. In D19324#420982 , @axionl wrote: > Just I like it as a modern design style and also avoiding some problems for the similarity of official icon, but if you mind that I can remove it. I think that even though the gr

D19324: Add code-oss icon

2019-02-26 Thread Noah Davis
ndavis added a comment. You also need to optimize the SVG. You can do that by using one of the three SVG optimizers on this page: https://invent.kde.org/ndavis/hig-kde-org/wikis/Icon-Workflow#svg-optimization I should add that to the HIG at some point in the future. REPOSITORY R266 Br

D19324: Add code-oss icon

2019-02-26 Thread Noah Davis
ndavis added a comment. I see you've kept the green on the light theme version instead of using the same icon for both versions. Is there a reason for this or do you just prefer it? This looks just about ready to land on the master branch, there are just a few more things you need to do

D19324: Add code-oss icon

2019-02-26 Thread Noah Davis
ndavis added a comment. Much better. Now for some questions and suggestions. Why does the icon use green on the top of the logo? The light theme version doesn't look bad, but isn't the official logo all blue? In general, we try to preserve the original branding. Why is the dark them

D19324: Add code-oss icon

2019-02-25 Thread Noah Davis
ndavis added a comment. In D19324#419766 , @axionl wrote: > I use the Gravit Designer (https://designer.io/) to design this icon, not the inkscape, but I think I can redraw it by inkscape. Please do. KDE software is only made with free an

D19324: Add code-oss icon

2019-02-25 Thread Noah Davis
ndavis added a comment. Weird. In Inkscape, the logo looks like raster graphics, but in Dolphin and Gwenview it looks like vector graphics. Something is seriously screwed up in this SVG. Did you use Inkscape? Can you explain what process you used to make this icon? F6636063: Screenshot_201

D18986: [breeze-icons] Add video camera icons

2019-02-20 Thread Noah Davis
ndavis added a comment. @ngraham If you include this in TWIP&U, use this image since it's slightly sharper on the 64px icon. @trickyricky26's `montage` is screwing up even though he's using the same command as me. F6626420: montage-breeze-Background.png

D18986: [breeze-icons] Add video camera icons

2019-02-20 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. LGTM! I really like how the 64px version turned out, especially that shotgun mic. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D18986 REVISION DETAIL https://phabricator.kde.org/D18986 To: trickyricky26, #vdg, hein, ndavis, rooty

D19020: [breeze-icons] Revamp system.svgz

2019-02-17 Thread Noah Davis
ndavis added a comment. In D19020#414317 , @rooty wrote: > In D19020#414300 , @abetts wrote: > > > Well, maybe it is time to call it and be done. I don't think we are going to please everyone right n

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

2019-02-15 Thread Noah Davis
ndavis added a comment. In D19030#412778 , @ngraham wrote: > Now we don't need `input-gaming` anymore. :) What happens if an application asks for a 22px `input-gaming` icon and not `input-gaming-symbolic`? REPOSITORY R266 Breeze Icons

D19020: [breeze-icons] Revamp system.svgz

2019-02-15 Thread Noah Davis
ndavis added a comment. In D19020#412584 , @broulik wrote: > What's the air conditioning do? suspend to disk? > > +1 on the moon for suspend Yes. The previous symbol was a sun-like symbol (22px old version left of 32px new version): h

D18940: Add battery icons

2019-02-14 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:b04959059668: Add battery icons (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18940?vs=51712&id=51730 REVISION DETAIL https://phabrica

D18940: Add battery icons

2019-02-14 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons BRANCH battery-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D18940 To: ndavis, #vdg, hein, ngraham Cc: broulik, ngraham, filipf, trickyricky26, kde-frameworks-devel, hein, michaelh, bruns

D18940: Add battery icons

2019-02-14 Thread Noah Davis
ndavis updated this revision to Diff 51712. ndavis added a comment. Change `status/22` and `status/22@2x` from Scalable to Fixed REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18940?vs=51462&id=51712 BRANCH battery-icons (branched from master) REVI

D18940: Add battery icons

2019-02-14 Thread Noah Davis
ndavis added a comment. In D18940#412125 , @ngraham wrote: > In D18940#411818 , @ndavis wrote: > > > Would changing `status/22` to Fixed cause a problem? It doesn't appear to cause any real issue whe

D18940: Add battery icons

2019-02-13 Thread Noah Davis
ndavis added a comment. This is the configuration for `status/32`: [status/32] Size=32 Context=Status Type=Fixed This currently prevents the 32px icons in this patch from being used: [status/22] Size=22 Context=Status Type=Scalable MinSize=22 M

D18986: [breeze-icons] Add video camera icons

2019-02-13 Thread Noah Davis
ndavis added a comment. In D18986#411771 , @rooty wrote: > Should it be a head on view? Or should it be a side view? Head on if you're going to use this style. Side if you're going to use the first style. > People also complain about

D18986: [breeze-icons] Add video camera icons

2019-02-13 Thread Noah Davis
ndavis added a comment. In D18986#411749 , @rooty wrote: > In D18986#411746 , @ndavis wrote: > > > In D18986#411735 , @rooty wrote: > > > > > https://co

D18986: [breeze-icons] Add video camera icons

2019-02-13 Thread Noah Davis
ndavis added a comment. In D18986#411735 , @rooty wrote: > https://commons.wikimedia.org/wiki/File:Icons8_flat_camcorder.svg > > Can we use this one it's so pretty? Well, we can't use that exact icon, but you can make something similar

D18986: [breeze-icons] Add video camera icons

2019-02-13 Thread Noah Davis
ndavis added a comment. In D18986#411719 , @rooty wrote: > Because of camera-photo.svg, and I also really like Plasma Blue. I'm open to suggestions, mockups, anything that would look better than the current 64 px icon. Interestingly, mos

D18986: [breeze-icons] Add video camera icons

2019-02-13 Thread Noah Davis
ndavis added a comment. For the color icon: Avoid using the plasma logo unnecessarily. In existing device icons that use it (I want to move away from using it), it's usually placed where a brand logo would go on a real product. Just so I can have an idea about how your design works, co

D18986: [breeze-icons] Add video camera icons

2019-02-13 Thread Noah Davis
ndavis added a comment. In D18986#411636 , @rooty wrote: > How about now? F6613626: image.png I made the monochrome version a little taller Breeze monochrome icons are primarily made of ellipses and

D18940: Add battery icons

2019-02-13 Thread Noah Davis
ndavis added a comment. In D18940#411319 , @broulik wrote: > The battery icon is composited of multiple SVG items layered ontop of each other, it doesn't just load a single icon. > > I'm in favor of adding proper battery icons to the Breeze i

D18940: Add battery icons

2019-02-13 Thread Noah Davis
ndavis added a comment. In D18940#411317 , @broulik wrote: > In D18940#411316 , @ndavis wrote: > > > Won't 3rd party themes contain their own icons? > > > Sure but in the style of a Plasma batte

D18940: Add battery icons

2019-02-13 Thread Noah Davis
ndavis added a comment. In D18940#411303 , @broulik wrote: > > maybe we can port the code to use these as icons from the icon theme rather than SVGs from the Plasma theme and then delete them from the Plasma theme > > And in the process brea

D18940: Add battery icons

2019-02-12 Thread Noah Davis
ndavis added a comment. In D18940#411154 , @ngraham wrote: > So I guess this means some duplication between the Breeze icon theme and the Breeze Plasma theme for a while, right? Not 100%. I need to make a device icon for an uninterruptibl

D18940: Add battery icons

2019-02-12 Thread Noah Davis
ndavis added a comment. In D18940#410649 , @trickyricky26 wrote: > I like it! > Would you consider moving the green charging to either the filled-in or the white part where the symbol is currently above the line where the filled-in part ends

D18940: Add battery icons

2019-02-12 Thread Noah Davis
ndavis added a comment. In D18940#410688 , @filipf wrote: > Nice. Shouldn't the plug here be green, same as everywhere else? > > F6611280: image.png This was fixed in the last change REPOSITORY

D18940: Add battery icons

2019-02-11 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18940 To: ndavis, #vdg, hein Cc: kde-frameworks-devel, hein, michaelh, ngraham, bruns

D18940: Add battery icons

2019-02-11 Thread Noah Davis
ndavis updated this revision to Diff 51462. ndavis added a comment. Fix missing PositiveText stylesheet for battery-020-charging REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18940?vs=51461&id=51462 BRANCH battery-icons (branched from master) REVI

D18940: Add battery icons

2019-02-11 Thread Noah Davis
ndavis added a comment. Not certain if I've got the `index.theme`s right REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18940 To: ndavis, #vdg, hein Cc: kde-frameworks-devel, hein, michaelh, ngraham, bruns

D18940: Add battery icons

2019-02-11 Thread Noah Davis
ndavis updated this revision to Diff 51461. ndavis added a comment. Add `status/32` to `index.theme` REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18940?vs=51460&id=51461 BRANCH battery-icons (branched from master) REVISION DETAIL https://phabri

D18940: Add battery icons

2019-02-11 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18940 To: ndavis, #vdg, hein Cc: kde-frameworks-devel, hein, michaelh, ngraham, bruns

D18940: Add battery icons

2019-02-11 Thread Noah Davis
ndavis created this revision. ndavis added reviewers: VDG, hein. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Adds battery icons at 16, 22 and 32 px. Adds `status/32` to `index.theme`. Includes sy

D18865: Change C/C++ header/source mimetype icons to circle/line style

2019-02-08 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:fdf910145bef: Change C/C++ header/source mimetype icons to circle/line style (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18865?vs=5121

D18865: Change C/C++ header/source mimetype icons to circle/line style

2019-02-08 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18865 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18865: Change C/C++ header/source mimetype icons to circle/line style

2019-02-08 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH text-x-c (branched from master) REVISION DETAIL https://phabricator

D18837: Fix missing shadows on C/C++ header mimetype icons

2019-02-08 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:0eea3019324f: Fix missing shadows on C/C++ header mimetype icons (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18837?vs=51150&id=51205

D18834: Change glowbar.svgz to smoother style

2019-02-08 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R242:054b494bb3f2: Change glowbar.svgz to smoother style (authored by ndavis). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18834?vs=51144&id=51154

D18834: Change glowbar.svgz to smoother style

2019-02-08 Thread Noah Davis
ndavis added a comment. Well, there's nothing wrong within the patch itself, so I'll land it. REPOSITORY R242 Plasma Framework (Library) BRANCH fix-glowbar (branched from master) REVISION DETAIL https://phabricator.kde.org/D18834 To: ndavis, #vdg, rooty Cc: rooty, rapiteanu, kde-frame

D18837: Fix missing shadows on C/C++ header mimetype icons

2019-02-08 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Some shadow objects had no fill because the gradients they referenced were missing. BU

D18834: Change glowbar.svgz to smoother style

2019-02-07 Thread Noah Davis
ndavis added a comment. In D18834#407534 , @rooty wrote: > You could make it smaller? It looks fine to me at the corners, it's the actual sidebar that's a little thick. > > I still like this diff though, I think that the master's too stipple

D18834: Change glowbar.svgz to smoother style

2019-02-07 Thread Noah Davis
ndavis added a comment. I suppose it's this, but it's somehow even worse with this patch: https://bugs.kde.org/show_bug.cgi?id=337712 I had a look through the Screen Edge effect code and while I'm no expert, I didn't see anything that would obviously make the corners large. REPOSITORY

D18834: Change glowbar.svgz to smoother style

2019-02-07 Thread Noah Davis
ndavis added a comment. For some reason, this version looks much larger in the corners. Was there a change to how the screen edge effect works? I didn't change the size of the corners in the SVGZ. REPOSITORY R242 Plasma Framework (Library) BRANCH fix-glowbar (branched from master) REVI

D18834: Change glowbar.svgz to smoother style

2019-02-07 Thread Noah Davis
ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH fix-glowbar (branched from master) REVISION DETAIL https://phabricator.kde.org/D18834 To: ndavis, #vdg, rooty Cc: rooty, rapiteanu, kde-frameworks-d

D18834: Change glowbar.svgz to smoother style

2019-02-07 Thread Noah Davis
ndavis added a comment. In D18834#407524 , @rooty wrote: > Wait I can do that? I didn't know I could do that :D Yes, but I should have said make sure you've given patches you want to approve a good look first. Use `arc patch D` so you can

D18834: Change glowbar.svgz to smoother style

2019-02-07 Thread Noah Davis
ndavis added a comment. If you like it, don't be afraid to hit "Approve" ;) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18834 To: ndavis, #vdg Cc: rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

2019-02-07 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18834 To: ndavis, #vdg Cc: rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

2019-02-07 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18834 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

2019-02-07 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18834 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

2019-02-07 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18834 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

2019-02-07 Thread Noah Davis
ndavis added a comment. JFYI, the whole embedded stylesheet thing doesn't work on gradients, so it doesn't matter if colors are hardcoded. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18834 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, n

D18834: Change glowbar.svgz to smoother style

2019-02-07 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY The old style was weird. When the screen edge feature was enabled for the sides of screens,

D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg

2019-02-07 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH gnumeric-font-16px (branched from master) REVISION DETAIL https://phabricator.kde.org/D18794 To: rooty, #vdg, ndavis, GB_2, ngraham Cc: GB_2, ngraham, ndavis, kde-frameworks

D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg

2019-02-06 Thread Noah Davis
ndavis requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18794 To: rooty, #vdg, ndavis Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg

2019-02-06 Thread Noah Davis
ndavis added a comment. Now that I've had a look at the icon, it's not aligned with the pixel grid. The original icon wasn't very well aligned either, but at least the top and bottom were. Shrinking down from one monochrome size to another without adjusting to fit the grid generally doesn't

D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg

2019-02-06 Thread Noah Davis
ndavis added a comment. In D18794#406854 , @rooty wrote: > Wow thanks @ndavis, scour shrinks it even more than svgcleaner does Not in my experience, but I'm glad it works well for you. REPOSITORY R266 Breeze Icons REVISION DETAIL htt

D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg

2019-02-06 Thread Noah Davis
ndavis added inline comments. INLINE COMMENTS > gnumeric-font.svg:60 > + + > style="color:#eff0f1;fill:currentColor;fill-opacity:1;stroke:none;stroke-width:0.7002" > + d="M 7.273454,3.33362 5.0638074,9.7294853 4.9817757,10.00032 4,12.667 H > 5.1054743 L 6.188813,9.7086519 H 9.8112

D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg

2019-02-06 Thread Noah Davis
ndavis added a comment. Hmm somehow I missed this. Here's a way to optimize it with a utility that's available in most distro repos (`scour`, `python-scour`): scour input.svg output.svg --enable-viewboxing --enable-id-stripping --enable-comment-stripping --shorten-ids --remove-descript

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

2019-02-05 Thread Noah Davis
ndavis accepted this revision. REPOSITORY R296 KDeclarative BRANCH improve-grid-view-kcm-inline-hover-button-contrast (branched from master) REVISION DETAIL https://phabricator.kde.org/D18649 To: ngraham, #vdg, #plasma, broulik, GB_2, ndavis Cc: Codezela, bruns, rizzitello, ndavis, andrea

D18702: Remove monochrome font preferences icon and improve font selection icon

2019-02-03 Thread Noah Davis
ndavis added a comment. Is this icon used by any other KDE software or 3rd party applications? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18702 To: GB_2, #vdg Cc: ndavis, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D18686: Add Cursors KCM icon

2019-02-02 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:befcc3791d6a: Add Cursors KCM icon (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18686?vs=50746&id=50747 REVISION DETAIL https://phabr

D18686: Add Cursors KCM icon

2019-02-02 Thread Noah Davis
ndavis updated this revision to Diff 50746. ndavis added a comment. Fix Breeze Dark REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18686?vs=50745&id=50746 BRANCH preferences-cursors (branched from master) REVISION DETAIL https://phabricator.kde.o

D18686: Add Cursors KCM icon

2019-02-02 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18686 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18686: Add Cursors KCM icon

2019-02-02 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH preferences-cursors (branched from master) REVISION DETAIL https://

D18662: Add and rename some YaST icons and symlinks

2019-02-02 Thread Noah Davis
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R266:cff0b5794d82: Add and rename some YaST icons and symlinks (authored by ndavis). CHANGED PRIOR TO COMMIT https://phab

D18662: Add and rename some YaST icon symlinks

2019-02-02 Thread Noah Davis
ndavis updated this revision to Diff 50739. ndavis added a comment. Update commit message REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18662?vs=50694&id=50739 BRANCH more-yast (branched from master) REVISION DETAIL https://phabricator.kde.org/D

D18662: Add and rename some YaST icons and symlinks

2019-02-02 Thread Noah Davis
ndavis retitled this revision from "Add and rename some YaST icon symlinks" to "Add and rename some YaST icons and symlinks". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18662 To: ndavis, #vdg Cc: hellcp, fvogt, ngraham, kde-frameworks-devel, michaelh, bruns

D18662: Add and rename some YaST icon symlinks

2019-02-02 Thread Noah Davis
ndavis added a comment. I think I'll just land this. It fixes a bug caused by my misunderstanding of how YaST currently works. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18662 To: ndavis, #vdg Cc: hellcp, fvogt, ngraham, kde-frameworks-devel, michaelh, bru

D18662: Add and rename some YaST icon symlinks

2019-02-02 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18662 To: ndavis, #vdg Cc: hellcp, fvogt, ngraham, kde-frameworks-devel, michaelh, bruns

D18662: Add and rename some YaST icon symlinks

2019-02-02 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18662 To: ndavis, #vdg Cc: hellcp, fvogt, ngraham, kde-frameworks-devel, michaelh, bruns

D18662: Add and rename some YaST icon symlinks

2019-02-02 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18662 To: ndavis, #vdg Cc: hellcp, fvogt, ngraham, kde-frameworks-devel, michaelh, bruns

D18662: Add and rename some YaST icon symlinks

2019-02-02 Thread Noah Davis
ndavis retitled this revision from "Add and rename some YaST icon symlinks because of Qt bugs" to "Add and rename some YaST icon symlinks". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18662 To: ndavis, #vdg Cc: hellcp, fvogt, ngraham, kde-frameworks-devel, mich

D18662: Add and rename some YaST icon symlinks because of Qt bugs

2019-02-02 Thread Noah Davis
ndavis added a subscriber: hellcp. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18662 To: ndavis, #vdg Cc: hellcp, fvogt, ngraham, kde-frameworks-devel, michaelh, bruns

<    5   6   7   8   9   10   11   12   13   14   >