[Differential] [Commented On] D3392: winutils_p.h: Restore compatibility with WinXP SDK

2016-11-16 Thread kfunk (Kevin Funk)
kfunk added a comment. And I meant this line: https://code.woboq.org/qt5/qtbase/src/corelib/io/qfsfileengine_win.cpp.html#547 (Woboq bug..., can't link the Windows version of `QFSFileEngine::drivers()`...) BRANCH master REVISION DETAIL https://phabricator.kde.org/D3392 EMAIL PREFERENCE

[Differential] [Commented On] D3392: winutils_p.h: Restore compatibility with WinXP SDK

2016-11-16 Thread kfunk (Kevin Funk)
kfunk added a comment. In https://phabricator.kde.org/D3392#63341, @brauch wrote: > Hm, there is at least one race condition here: thread A does old = ::SetErrorMode(...), then if before it resets it thread B does the same, then the old mode might never be restored. We can put a mutex bu