D10335: balooctl monitor: Exit w/o valid dbus interface

2018-02-06 Thread Michael Heidelbach
michaelh created this revision. michaelh added reviewers: Baloo, Frameworks. Restricted Application added a project: Frameworks. michaelh requested review of this revision. REVISION SUMMARY Exit the application instead of just stopping the event loop TEST PLAN $ balooctl monitor || echo "fa

D10335: balooctl monitor: Exit w/o valid dbus interface

2018-02-06 Thread Michael Heidelbach
michaelh added a comment. This is the second time I could "resolve" a problem by throwing in a oneshot timer, see also https://phabricator.kde.org/D9590. I have the feeling something else is wrong here and regard this more as a workaround than a solution. Please comment. REPOSITORY R293

D10335: balooctl monitor: Exit w/o valid dbus interface

2018-02-06 Thread Alexey Min
alexeymin added a comment. `quit()` and `exit(0)` do the same thing - they all stop event loop, caused by `QCoreApplication::exec()`. And I don't understand how does timer help? What is happening without singleshot timer? INLINE COMMENTS > monitorcommand.cpp:55 > +m_out <<

D10335: balooctl monitor: Exit w/o valid dbus interface

2018-02-16 Thread Michael Heidelbach
michaelh added a comment. @alexeymin: Sorry, for the huge delay. > And I don't understand how does timer help? What is happening without singleshot timer? I don't quite understand either. Without it you won't get your prompt back until you Ctrl+C. REPOSITORY R293 Baloo REVISIO

D10335: balooctl monitor: Exit w/o valid dbus interface

2018-02-16 Thread Michael Heidelbach
michaelh abandoned this revision. michaelh added a comment. Superseded by D10578 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10335 To: michaelh, #baloo, #frameworks Cc: alexeymin, michaelh