D10807: fileindexerconfig: Exclude Vaults by default

2018-03-09 Thread Michael Heidelbach
michaelh added a comment. In D10807#222173 , @rkflx wrote: > Did you already look at which approach Tracker uses regarding filesystems? Are they just indexing everything? Nope, good you reminded me. Made a note for myself T8066

D10807: fileindexerconfig: Exclude Vaults by default

2018-03-09 Thread Henrik Fehlauer
rkflx added a comment. Did you already look at which approach Tracker uses regarding filesystems? Are they just indexing everything? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham, #plasma Cc: rkflx, alexeymin, plasma-

D10807: fileindexerconfig: Exclude Vaults by default

2018-03-09 Thread Michael Heidelbach
michaelh abandoned this revision. michaelh added a comment. Too naive approach REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham, #plasma Cc: rkflx, alexeymin, plasma-devel, ivan, nicolasfella, ashaposhnikov, michaelh, sp

D10807: fileindexerconfig: Exclude Vaults by default

2018-02-25 Thread Michael Heidelbach
michaelh added a comment. In D10807#213250 , @rkflx wrote: > What about users who manually create and mount FUSE-type encrypted directories? Plasma Vault is just a nice interface for this workflow, after all. Good point. > A more gen

D10807: fileindexerconfig: Exclude Vaults by default

2018-02-25 Thread Henrik Fehlauer
rkflx added a comment. What about users who manually create and mount FUSE-type encrypted directories? Plasma Vault is just a nice interface for this workflow, after all. A more general approach would be to look at the filesystem type in `mount` (do we have an API for that?). I'd imagine

D10807: fileindexerconfig: Exclude Vaults by default

2018-02-24 Thread Michael Heidelbach
michaelh added a comment. I was thinking in the same direction. When the mountpoint of a vault is changed (or new) a warning message about baloo's activity should be displayed. The message should be displayed regardless of baloo's enabled state. There's plenty of space for that in the dialog

D10807: fileindexerconfig: Exclude Vaults by default

2018-02-24 Thread Alexey Min
alexeymin added a comment. Maybe when a new vault is configured, it should add itself to baloo exceptions. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham, #plasma Cc: alexeymin, plasma-devel, ivan, nicolasfella, ashapo

D10807: fileindexerconfig: Exclude Vaults by default

2018-02-24 Thread Michael Heidelbach
michaelh added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham, #plasma Cc: plasma-devel, ivan, nic

D10807: fileindexerconfig: Exclude Vaults by default

2018-02-24 Thread Michael Heidelbach
michaelh added a comment. This is not a viable approach. Any vaults created after baloo is configured may be indexed (unless they are inside ~/Vaults, of course). For the near future I see no other way to exclude vaults from being indexed other than this one. :-( REPOSITORY R293 Baloo

D10807: fileindexerconfig: Exclude Vaults by default

2018-02-24 Thread Michael Heidelbach
michaelh added a comment. In D10807#212953 , @nicolasfella wrote: > I honestly don't know. > > @ivan any idea? Just found it. `~/config/plasmavaultrc` REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To:

D10807: fileindexerconfig: Exclude Vaults by default

2018-02-24 Thread Nicolas Fella
nicolasfella added a subscriber: ivan. nicolasfella added a comment. I honestly don't know. @ivan any idea? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham Cc: ivan, nicolasfella, ashaposhnikov, michaelh, kmorwinski

D10807: fileindexerconfig: Exclude Vaults by default

2018-02-24 Thread Michael Heidelbach
michaelh added a comment. In D10807#212948 , @nicolasfella wrote: > You have to hit next a couple of times I saw it. Ok, now what? How to find out where the vaults are? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde

D10807: fileindexerconfig: Exclude Vaults by default

2018-02-24 Thread Nicolas Fella
nicolasfella added a comment. You have to hit next a couple of times REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham Cc: nicolasfella, ashaposhnikov, michaelh, kmorwinski, spoorun, alexeymin

D10807: fileindexerconfig: Exclude Vaults by default

2018-02-24 Thread Michael Heidelbach
michaelh added a comment. F5728284: image.png REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham Cc: nicolasfella, ashaposhnikov, michaelh, kmorwinski, spoorun, alexeymin

D10807: fileindexerconfig: Exclude Vaults by default

2018-02-24 Thread Nicolas Fella
nicolasfella added a comment. When creating a Vault you can choose any location for it. ~/Vaults is just the default REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham Cc: nicolasfella, ashaposhnikov, michaelh, kmorwinski,

D10807: fileindexerconfig: Exclude Vaults by default

2018-02-24 Thread Nicolas Fella
nicolasfella added a comment. F5728282: Screenshot_20180224_212932.png REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham Cc: nicolasfella, ashaposhnikov, michaelh, kmorwinski, spooru

D10807: fileindexerconfig: Exclude Vaults by default

2018-02-24 Thread Michael Heidelbach
michaelh added a comment. In D10807#212942 , @nicolasfella wrote: > Vault can also be mounted in other directories than ~/Vaults How is that done? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michael

D10807: fileindexerconfig: Exclude Vaults by default

2018-02-24 Thread Nicolas Fella
nicolasfella added a comment. Vault can also be mounted in other directories than ~/Vaults REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham Cc: nicolasfella, ashaposhnikov, michaelh, kmorwinski, spoorun, alexeymin

D10807: fileindexerconfig: Exclude Vaults by default

2018-02-24 Thread Michael Heidelbach
michaelh created this revision. michaelh added reviewers: Baloo, Frameworks, ngraham. michaelh added projects: Baloo, Frameworks. michaelh requested review of this revision. REVISION SUMMARY Quick bug fix BUG:390830 TEST PLAN (upcoming) make test REPOSITORY R293 Baloo BRANCH exclud