D10820: Send slave's polkit authorization status to the host

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ea4329c36830: Send slaves polkit authorization status to the host (authored by chinmoyr). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10820?vs=30333=31252#toc REPOSITORY R241 KIO

D10820: Send slave's polkit authorization status to the host

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH D10820 REVISION DETAIL https://phabricator.kde.org/D10820 To: chinmoyr, dfaure Cc: anthonyfieroni, #frameworks, michaelh, ngraham

D10820: Send slave's polkit authorization status to the host

chinmoyr updated this revision to Diff 30333. chinmoyr added a comment. Added the missing assignment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10820?vs=30332=30333 BRANCH D10820 REVISION DETAIL https://phabricator.kde.org/D10820 AFFECTED FILES

D10820: Send slave's polkit authorization status to the host

dfaure added inline comments. INLINE COMMENTS > anthonyfieroni wrote in slavebase.cpp:154 > it = m_tempAuths.erase(it); > } else { > ++it; > } You forgot the `it =` in front. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10820 To: chinmoyr, dfaure Cc:

D10820: Send slave's polkit authorization status to the host

chinmoyr updated this revision to Diff 30332. chinmoyr marked 2 inline comments as done. chinmoyr added a comment. 1. Made method const. 2. Increment iterator only if erasing failed. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10820?vs=28541=30332 BRANCH

D10820: Send slave's polkit authorization status to the host

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > slavebase.cpp:150 > +#ifdef Q_OS_UNIX > +QSet::const_iterator it = m_tempAuths.begin(); > +while (it != m_tempAuths.end()) { This can't be a

D10820: Send slave's polkit authorization status to the host

anthonyfieroni added inline comments. INLINE COMMENTS > slavebase.cpp:154 > +if (action.status() != KAuth::Action::AuthorizedStatus) { > +m_tempAuths.erase(it); > +} it = m_tempAuths.erase(it); } else { ++it; } REPOSITORY R241 KIO REVISION

D10820: Send slave's polkit authorization status to the host

chinmoyr added a dependency: D11010: Add MSG_SLAVE_STATUS_V2 to slave interface. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10820 To: chinmoyr, dfaure Cc: #frameworks, michaelh

D10820: Send slave's polkit authorization status to the host

chinmoyr updated this revision to Diff 28541. chinmoyr added a comment. Added method updateTempAuthStatus() to take care of cleaning. Rebased on D11010 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10820?vs=27993=28541

D10820: Send slave's polkit authorization status to the host

chinmoyr added a dependent revision: D10641: Revoke temporary authorization of KIO slave before sending status to IdleSlave. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10820 To: chinmoyr, dfaure Cc: #frameworks, michaelh, kmorwinski

D10820: Send slave's polkit authorization status to the host

chinmoyr edited the summary of this revision. chinmoyr added a dependency: D10818: Store PolicyKit action which the slave is authorized to perform. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10820 To: chinmoyr, dfaure Cc: #frameworks, michaelh, kmorwinski

D10820: Send slave's polkit authorization status to the host

chinmoyr added a dependent revision: D10822: Store temporary authorization status in IdleSlave. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10820 To: chinmoyr, dfaure Cc: #frameworks, michaelh, kmorwinski

D10820: Send slave's polkit authorization status to the host

chinmoyr created this revision. chinmoyr added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. chinmoyr requested review of this revision. REVISION SUMMARY Send slave's authorization status along with the oher status