D11285: Introduce sanitizer class

michaelh added a task: T8250: Sanitize the database. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11285 To: michaelh, #baloo, #frameworks, ngraham, mlaurent Cc: mlaurent, ngraham, smithjd, ashaposhnikov, michaelh, astippich, spoorun, bruns, alexeymin

D11285: Introduce sanitizer class

This revision was automatically updated to reflect the committed changes. Closed by commit R293:9de78becc063: Introduce sanitizer class (authored by michaelh). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11285?vs=29683=29684 REVISION DETAIL

D11285: Introduce sanitizer class

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. +2 for me but I don't know baloo code :) REPOSITORY R293 Baloo BRANCH sanitize-class (branched from master) REVISION DETAIL https://phabricator.kde.org/D11285 To: michaelh,

D11285: Introduce sanitizer class

michaelh marked 3 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11285 To: michaelh, #baloo, #frameworks, ngraham, mlaurent Cc: mlaurent, ngraham, smithjd, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, alexeymin

D11285: Introduce sanitizer class

michaelh updated this revision to Diff 29683. michaelh added a comment. - Turn FileInfo into a struct again REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11285?vs=29594=29683 BRANCH sanitize-class (branched from master) REVISION DETAIL

D11285: Introduce sanitizer class

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > databasesanitizer.cpp:46 > +public: > +FileInfo(const quint32 d = 0, const quint32 i = 0, > +const QString& u = QString(),

D11285: Introduce sanitizer class

michaelh added inline comments. INLINE COMMENTS > databasesanitizer.cpp:163 > +/** > +* Create a list of \a FileInfo items to stdout. > +* Before landing this will become Create a list of \a FileInfo items and print it to stdout. REPOSITORY R293 Baloo REVISION DETAIL

D11285: Introduce sanitizer class

michaelh added a comment. In D11285#226298 , @mlaurent wrote: > Is it possible to create an autotest for this class ? This is where it gets complicated. Essentially I can test only for sane databases, but that's useless. Or I need to

D11285: Introduce sanitizer class

michaelh marked 4 inline comments as done. michaelh added a comment. There were some conflicts I had to solve with this. Because it is not completely clear to me where this is going I wanted to be safe and used a d-pointer. As a consequence this class does the printing which I prefer to be

D11285: Introduce sanitizer class

michaelh updated this revision to Diff 29594. michaelh added a comment. - Apply suggested changes - Put method descriptions in their correct place REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11285?vs=29405=29594 BRANCH sanitize-class (branched from

D11285: Introduce sanitizer class

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > databasesanitizer.cpp:44 > +struct FileInfo { > +quint32 deviceId; > +quint32 inode; initialize value by default please >

D11285: Introduce sanitizer class

mlaurent added a comment. Is it possible to create an autotest for this class ? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11285 To: michaelh, #baloo, #frameworks, ngraham, mlaurent Cc: mlaurent, ngraham, smithjd, ashaposhnikov, michaelh, spoorun, nicolasfella,

D11285: Introduce sanitizer class

michaelh added inline comments. INLINE COMMENTS > databasesanitizer.cpp:200 > + > +DocumentUrlDB DatabaseSanitizer::getDocuments(Transaction* txn) > +{ This is the best I could think of to make `getDocuments` accessible to DatabaseSanitizerImpl. But I don't like it. This method definitely

D11285: Introduce sanitizer class

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks good to me! REPOSITORY R293 Baloo BRANCH sanitize-class (branched from master) REVISION DETAIL https://phabricator.kde.org/D11285 To: michaelh, #baloo, #frameworks, ngraham

D11285: Introduce sanitizer class

michaelh added a dependent revision: D11287: Introduce baloodb CLI tool. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11285 To: michaelh, #baloo, #frameworks Cc: smithjd, ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

D11285: Introduce sanitizer class

michaelh created this revision. michaelh added reviewers: Baloo, Frameworks. Restricted Application added projects: Frameworks, Baloo. michaelh requested review of this revision. REVISION SUMMARY Due to device ids being inconstant duplicates are introduced to the database. I. e. multiple