D11924: [WIP] Add "SkipSwitcher" to API

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH skip-switcher (branched from master) REVISION DETAIL https://phabricator.kde.org/D11924 To: sharvey, hein, graesslin Cc: ngraham, graesslin, apol, #frameworks, michaelh

D11924: [WIP] Add "SkipSwitcher" to API

sharvey marked 3 inline comments as done. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D11924 To: sharvey, hein, graesslin Cc: ngraham, graesslin, apol, #frameworks, michaelh

D11924: [WIP] Add "SkipSwitcher" to API

sharvey updated this revision to Diff 31330. sharvey added a comment. - Add `_KDE` prefix to SkipSwitcher state; correct enum REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11924?vs=31307&id=31330 BRANCH skip-switcher (branched from master) REVISI

D11924: [WIP] Add "SkipSwitcher" to API

sharvey added a subscriber: ngraham. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D11924 To: sharvey, hein, graesslin Cc: ngraham, graesslin, apol, #frameworks, michaelh

D11924: [WIP] Add "SkipSwitcher" to API

sharvey marked an inline comment as done. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D11924 To: sharvey, hein, graesslin Cc: graesslin, apol, #frameworks, michaelh, ngraham

D11924: [WIP] Add "SkipSwitcher" to API

sharvey added a comment. In D11924#240057 , @graesslin wrote: > In D11924#240045 , @graesslin wrote: > > > I'm not sure whether we can add elements to the states. > > An implementati

D11924: [WIP] Add "SkipSwitcher" to API

graesslin added a comment. In D11924#240045 , @graesslin wrote: > I'm not sure whether we can add elements to the states. Just checked: An implementation MAY add new atoms to this list. Implementations without extensions MUST ignore

D11924: [WIP] Add "SkipSwitcher" to API

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. I'm not sure whether we can add elements to the states. INLINE COMMENTS > netwininfotestwm.cpp:432 > const QByteArray skipTaskbar = > QByteArrayLiteral("_NET_WM_S

D11924: [WIP] Add "SkipSwitcher" to API

sharvey marked an inline comment as done. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D11924 To: sharvey, hein Cc: apol, #frameworks, michaelh, ngraham

D11924: [WIP] Add "SkipSwitcher" to API

sharvey updated this revision to Diff 31307. sharvey added a comment. - Add `@since 5.45` to SkipSwitcher doxygen comments REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11924?vs=31294&id=31307 BRANCH skip-switcher (branched from master) REVISION

D11924: [WIP] Add "SkipSwitcher" to API

sharvey added a comment. In D11924#239922 , @apol wrote: > 5.44 was just released, so I'd assume it's 5.45 (or we can fix change it later if it takes us longer to merge). I took a minute to think it through and came to the conclusion of `

D11924: [WIP] Add "SkipSwitcher" to API

apol added a comment. 5.44 was just released, so I'd assume it's 5.45 (or we can fix change it later if it takes us longer to merge). REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D11924 To: sharvey, hein Cc: apol, #frameworks, michaelh, ngraham

D11924: [WIP] Add "SkipSwitcher" to API

sharvey added inline comments. INLINE COMMENTS > apol wrote in netwm_def.h:492 > add `@since 5.45`? Will it be `5.45` for KWayland as well? There were `@since` tags in what I duplicated, but I wasn't certain which version. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.

D11924: [WIP] Add "SkipSwitcher" to API

apol added inline comments. INLINE COMMENTS > netwm_def.h:492 > /** > + indicates that a window should not be included on a switcher. > +**/ add `@since 5.45`? REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D11924 To: sharvey, hein Cc:

D11924: [WIP] Add "SkipSwitcher" to API

sharvey edited the summary of this revision. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D11924 To: sharvey, hein Cc: #frameworks, michaelh, ngraham

D11924: [WIP] Add "SkipSwitcher" to API

sharvey added a comment. NOTE: This is a junior job and a work in progress! After discussion in BUG 375921 , it was decided to add `SkipSwitcher` to the KWin API. It's a junior job and my first submission to the KWin/KWayland/KWindowSystem fam

D11924: [WIP] Add "SkipSwitcher" to API

sharvey created this revision. sharvey added a reviewer: hein. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. sharvey requested review of this revision. REVISION SUMMARY Adding "SkipSwitcher" to API, stemming from discussion in BUG 37