D12734: Scale up folder icon before creating preview overlays

This revision was automatically updated to reflect the committed changes. Closed by commit R320:bafc90d730f2: Scale up folder icon before creating preview overlays (authored by muhlenpfordt). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12734?vs=33822&id=

D12734: Scale up folder icon before creating preview overlays

rkflx added a comment. In D12734#262368 , @muhlenpfordt wrote: > Ok to commit? Sure, go ahead 👍 REPOSITORY R320 KIO Extras BRANCH scale-up-folder-icon (branched from Applications/18.04) REVISION DETAIL https://phabricator.kde.org

D12734: Scale up folder icon before creating preview overlays

muhlenpfordt added a comment. In D12734#259515 , @rkflx wrote: > Nevertheless, let's check the impact of this again: https://lxr.kde.org/ident?_i=thumbForDirectory > Does not look too critical to me, and we probably tested most of the code pa

D12734: Scale up folder icon before creating preview overlays

muhlenpfordt updated this revision to Diff 33822. muhlenpfordt added a comment. Rebase to `Applications/18.04` REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12734?vs=33749&id=33822 BRANCH scale-up-folder-icon (branched from Applications/18.04) REVIS

D12734: Scale up folder icon before creating preview overlays

rkflx added a comment. In D12734#259445 , @muhlenpfordt wrote: > I wanted to be careful here since I'm a bit afraid of changing library functions. If you think it's ok for `Applications/18.04` I'll rebase it. How else would you fix probl

D12734: Scale up folder icon before creating preview overlays

muhlenpfordt added a comment. Forgot to mention this... There's a nice test application in `kio` for viewing a folder's preview in any desired size (created by `KIO::PreviewJob`): `previewtest`. Just enter the full path to the folder here. REPOSITORY R320 KIO Extras BRANCH master REV

D12734: Scale up folder icon before creating preview overlays

muhlenpfordt added a comment. In D12734#259336 , @rkflx wrote: > +1, but I'd feel a bit uncomfortable (almost) self-approving my own patch (sans the `qMax`) here, so perhaps wait until the end of the week for any other opinions before committing

D12734: Scale up folder icon before creating preview overlays

rkflx accepted this revision. rkflx added a comment. This revision is now accepted and ready to land. +1, but I'd feel a bit uncomfortable (almost) self-approving my own patch (sans the `qMax`) here, so perhaps wait until the end of the week for any other opinions before committing. BTW,

D12734: Scale up folder icon before creating preview overlays

muhlenpfordt added a reviewer: Frameworks. muhlenpfordt added subscribers: rkflx, ngraham. muhlenpfordt added a comment. Also see D12509 for Gwenview effects on this issue. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D12734