D19455: [knotification] compile without deprecated methods

dfaure added a comment. OK, it looks like everyone is waiting on everyone else in this discussion. Done now: https://commits.kde.org/knotifications/adc20218571941d19281ad81520aec62e195b355 REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D19455 To: mlauren

D19455: [knotification] compile without deprecated methods

aacid added a comment. In D19455#457849 , @bcooksley wrote: > I'm fine with either fix, any objection to that being committed directly? Sorry if you were waiting for me, sure just go ahead REPOSITORY R289 KNotifications REVISION DETAI

D19455: [knotification] compile without deprecated methods

mlaurent added a comment. "I'm fine with either fix, any objection to that being committed directly?" no problem for me REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D19455 To: mlaurent, dfaure Cc: aacid, bcooksley, kde-frameworks-devel, michaelh, ngraham,

D19455: [knotification] compile without deprecated methods

bcooksley added a comment. I'm fine with either fix, any objection to that being committed directly? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D19455 To: mlaurent, dfaure Cc: aacid, bcooksley, kde-frameworks-devel, michaelh, ngraham, bruns

D19455: [knotification] compile without deprecated methods

mlaurent added a comment. +1 with albert idea. Or in CMakeLists.txt if (NOT APPLE) add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x050d00) endif() As I can't compile against MacOsX we can exclude it. It will fix when we will switch to qt6 by os dev. REPOSITORY R289 KNo

D19455: [knotification] compile without deprecated methods

aacid added a comment. In D19455#457367 , @bcooksley wrote: > This change has broken builds on macOS. > Please see https://binary-factory.kde.org/view/MacOS/job/Kig_Nightly_macos/407/console > > Whilst not documented in the Qt Documentati

D19455: [knotification] compile without deprecated methods

bcooksley added a comment. This change has broken builds on macOS. Please see https://binary-factory.kde.org/view/MacOS/job/Kig_Nightly_macos/407/console Whilst not documented in the Qt Documentation, the `qmacfunctions.h` header (which is what is included by `#include `) has the foll

D19455: [knotification] compile without deprecated methods

This revision was automatically updated to reflect the committed changes. Closed by commit R289:6a9ba38e3ea9: [knotification] compile without deprecated methods (authored by mlaurent). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19455?vs=52925&id=530

D19455: [knotification] compile without deprecated methods

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH compile_without_deprecated_method (branched from master) REVISION DETAIL https://phabricator.kde.org/D19455 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraha

D19455: [knotification] compile without deprecated methods

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without deprecated method TEST PLAN autotest ok REPOSITORY R289 KNoti