D19996: WIP Add a global test for insecure http: URLs used in code or documentation

winterz added a comment. FYI: Today I added a Krazy checker to do this. Should see results on the EBN in a day or 2. Although I am skipping the .htignore's, there will still be lots of false positives especially in the test programs. Let's see what happens. -Allen REPOSITORY

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

vkrause added a comment. In D19996#480571 , @kossebau wrote: > Any chance this could not be done by abusing KDECMakeSettings.cmake as injection vector? I completely agree that this is a rather hacky approach. IMHO the challenge here is

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

kossebau added a comment. Any chance this could not be done by abusing KDECMakeSettings.cmake as injection vector? I know you are just following the example of what was done for appstreamcli, but IMHO this has already been a bad hack, screwing over the fine granular design of all the ECM

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

knauss added a task: T10716: Add check for accidental http: usage. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D19996 To: vkrause Cc: winterz, knauss, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

knauss updated this revision to Diff 54680. knauss added a comment. fixing a typo. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19996?vs=54679=54680 BRANCH arcpatch-D19996 REVISION DETAIL https://phabricator.kde.org/D19996 AFFECTED

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

knauss updated this revision to Diff 54679. knauss added a comment. make parallel network requests. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19996?vs=54663=54679 BRANCH arcpatch-D19996 REVISION DETAIL

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

knauss updated this revision to Diff 54663. knauss added a comment. complete diff. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19996?vs=54662=54663 BRANCH arcpatch-D19996 REVISION DETAIL https://phabricator.kde.org/D19996 AFFECTED

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

knauss updated this revision to Diff 54662. knauss added a comment. now with glob matching and another round of renaming blacklist files. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19996?vs=54640=54662 BRANCH arcpatch-D19996 REVISION

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

knauss updated this revision to Diff 54640. knauss added a comment. remove BLACKLSIT for httpcheck REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19996?vs=54639=54640 BRANCH arcpatch-D19996 REVISION DETAIL

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

knauss updated this revision to Diff 54639. knauss added a comment. add httpupdate and split out blacklist file REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19996?vs=54617=54639 BRANCH arcpatch-D19996 REVISION DETAIL

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

knauss added a comment. In D19996#436824 , @winterz wrote: > this would be a nice addition to Krazy. on my todo list. we are actually planing to push the list of blacklisted matches to a single file, so other scripts can take the list

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

winterz added a comment. this would be a nice addition to Krazy. on my todo list. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D19996 To: vkrause Cc: winterz, knauss, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

vkrause added inline comments. INLINE COMMENTS > cgiboudeaux wrote in KDECMakeSettings.cmake:189 > PythonInterp is also not a solution :) See 6c1db934e > > in ki18n. > > CMake 3.5.0 was found acceptable for most

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

knauss updated this revision to Diff 54617. knauss added a comment. search for http://\S and update blacklist. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19996?vs=54615=54617 BRANCH arcpatch-D19996 REVISION DETAIL

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

cgiboudeaux added inline comments. INLINE COMMENTS > vkrause wrote in KDECMakeSettings.cmake:189 > Right, the feature is just silently ignored in older versions. We can > probably switch that to PythonIterp if we want this for older versions as > well. But let's first see if this approach

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

vkrause added inline comments. INLINE COMMENTS > cgiboudeaux wrote in KDECMakeSettings.cmake:189 > FindPython3.cmake only exists in CMake >= 3.12.0 Right, the feature is just silently ignored in older versions. We can probably switch that to PythonIterp if we want this for older versions as

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

knauss updated this revision to Diff 54615. knauss added a comment. add more excludes. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19996?vs=54613=54615 BRANCH arcpatch-D19996 REVISION DETAIL https://phabricator.kde.org/D19996 AFFECTED

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

knauss updated this revision to Diff 54613. knauss added a comment. update http regex REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19996?vs=54612=54613 BRANCH arcpatch-D19996 REVISION DETAIL https://phabricator.kde.org/D19996 AFFECTED

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

knauss updated this revision to Diff 54612. knauss added a comment. update python script. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19996?vs=54611=54612 BRANCH arcpatch-D19996 REVISION DETAIL https://phabricator.kde.org/D19996

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

cgiboudeaux added inline comments. INLINE COMMENTS > KDECMakeSettings.cmake:189 > > +find_package(Python3 COMPONENTS Interpreter QUIET) > +function(httpcheck) FindPython3.cmake only exists in CMake >= 3.12.0 REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This is supposed to trigger a unit test failure when using http: rather than https: