D20526: fix extracting of some properties to match what was writen

astippich updated this revision to Diff 60334. astippich added a comment. - remove usage of contactsFromString entirely REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20526?vs=56170&id=60334 BRANCH arcpatch-D20526 REVISION DETAIL https://phabric

D20526: fix extracting of some properties to match what was writen

astippich commandeered this revision. astippich edited reviewers, added: mgallien; removed: astippich. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20526 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, ashaposhn

D20526: fix extracting of some properties to match what was writen

mgallien added a comment. In D20526#483910 , @astippich wrote: > @mgallien Are you going to update? There are bug reports which will also be fixed by this, so it would be nice to get this in. > Or do you mind if I take over? I would l

D20526: fix extracting of some properties to match what was writen

astippich added a comment. @mgallien Are you going to update? There are bug reports which will also be fixed by this, so it would be nice to get this in. Or do you mind if I take over? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20526 To: mgallien, astip

D20526: fix extracting of some properties to match what was writen

ngraham edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20526 To: mgallien, astippich, bruns Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abraha

D20526: fix extracting of some properties to match what was writen

astippich requested changes to this revision. astippich added a comment. This revision now requires changes to proceed. In D20526#449780 , @bruns wrote: > In D20526#449560 , @astippich wrote: > > > I

D20526: fix extracting of some properties to match what was writen

bruns added a comment. In D20526#449560 , @astippich wrote: > IMHO for searching, the separation from a single string into multiple entries is the best thing to do, from a metadata editing point of view not so much. > How about inserting the

D20526: fix extracting of some properties to match what was writen

astippich added a comment. IMHO for searching, the separation from a single string into multiple entries is the best thing to do, from a metadata editing point of view not so much. How about inserting the TStringList entry by entry, without using the contactsFromString method? That would ma

D20526: fix extracting of some properties to match what was writen

mgallien created this revision. mgallien added reviewers: astippich, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. mgallien requested review of this revision. REVISION SUMMARY Currently, one can write and read through taglib extractor and