elvisangelaccio added inline comments.
INLINE COMMENTS
> pajamapants3000 wrote in ktextedit.cpp:373
> Thank you broulik! Could we use a `QScopedPointer` here? I see them
> throughout the KDE source, but not often for dialogs. The krazy analysis
> looked for `QPointer`, referencing blog
pajamapants3000 added inline comments.
INLINE COMMENTS
> elvisangelaccio wrote in krichtextwidget.cpp:638
> Ah of course. I didn't notice it was `exec()` that was being called.
Coming back after two months, even I thought this looked wrong at first. I will
endeavor to make my intent clearer,
broulik added inline comments.
INLINE COMMENTS
> ktextedit.cpp:373
> +
> +delete dialog;
> }
You can do `dialog->setAttribute(Qt::WA_DeleteOnClose);` when creating the
dialog instead of an explicit delete call
REPOSITORY
R310 KTextWidgets
BRANCH
krazy-50b2564 (branched from master)
pajamapants3000 added a comment.
Thank you for the feedback and approval! I don't have the access needed to
land a change, what should I do next? I would certainly appreciate someone else
landing it for me. Let me know, thanks!
REPOSITORY
R310 KTextWidgets
BRANCH
krazy-50b2564
elvisangelaccio accepted this revision.
elvisangelaccio added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> vkrause wrote in krichtextwidget.cpp:638
> This is unusual, but it's the right way around. The point of this is to check
> if the dialog has been
vkrause added inline comments.
INLINE COMMENTS
> elvisangelaccio wrote in krichtextwidget.cpp:638
> This should be `linkDialog && linkDialog->exec()`
This is unusual, but it's the right way around. The point of this is to check
if the dialog has been deleted during the sub-eventloop behind
elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> krichtextwidget.cpp:638
>
> -if (linkDialog->exec()) {
> +if (linkDialog->exec() && linkDialog) {
>
pajamapants3000 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pajamapants3000 requested review of this revision.
REVISION SUMMARY
Resolved all issues discovered by the krazy plugins: crashy, explicit.
Other issues remain; I left
