D22801: [KIO] silence a QFileInfo warning

rjvbb added a comment. Whatever, I'm staying at 5.60.0 anyway, with whatever patches I deem appropriate. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22801 To: rjvbb, #frameworks, dfaure Cc: dfaure, meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, br

D22801: [KIO] silence a QFileInfo warning

dfaure added a comment. I disagree. Invalid method call, you get a warning already from Qt, no need to bloat this method more. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22801 To: rjvbb, #frameworks, dfaure Cc: dfaure, meven, kde-frameworks-devel, LeGast00n, GB_2,

D22801: [KIO] silence a QFileInfo warning

rjvbb added a comment. I might (if I can find the trouble location) but IMHO KIO should still account for the possibility of this situation too (or more in general, bail out this function for any path that cannot be a mountpoint). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.

D22801: [KIO] silence a QFileInfo warning

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. The bug is in the caller, fix it there. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22801 To: rjvbb, #frameworks, dfaure Cc: dfaure, meven, kde-framework

D22801: [KIO] silence a QFileInfo warning

rjvbb added a comment. > I disagree since it will change the current precondition of the function for the need of one of its users. In that case the warning could be made to be a qDebug, and that user can configure his/her logging setting so the category used will always be printed.

D22801: [KIO] silence a QFileInfo warning

meven added a subscriber: dfaure. meven added a comment. In D22801#561989 , @rjvbb wrote: > Are you not seeing these for instance when browsing an MSWin share in Dolphin (with the same or newer versions of kio-extras, Samba and MSWin)?ç I

D22801: [KIO] silence a QFileInfo warning

rjvbb added a comment. Are you not seeing these for instance when browsing an MSWin share in Dolphin (with the same or newer versions of kio-extras, Samba and MSWin)? I tried to figure out where they came from but failed because of the async nature of the chain of events. I presume the e

D22801: [KIO] silence a QFileInfo warning

meven added a comment. The issue could be as well located in previewjob.cpp. Could you debug why KMountPoint::List::findByPath is called with an empty string or non-existing file. We might want to prevent this to happen instead. REPOSITORY R241 KIO REVISION DETAIL https://phabricator

D22801: [KIO] silence a QFileInfo warning

rjvbb set the repository for this revision to R241 KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22801 To: rjvbb, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22801: [KIO] silence a QFileInfo warning

rjvbb updated this revision to Diff 62715. rjvbb edited the summary of this revision. rjvbb added a comment. It's probably not a bad idea too to return early if ever the computed `realname` is empty, and avoid the iteration which should be pointless in that case. Right?! CHANGES SINCE LAST U

D22801: [KIO] silence a QFileInfo warning

rjvbb created this revision. rjvbb added a reviewer: Frameworks. Herald added a project: Frameworks. rjvbb requested review of this revision. REVISION SUMMARY Prevent qWarning() messages that can arise when browsing samba shares: QFileInfo::absolutePath: Constructed with empty filename