dfaure closed this revision.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D24014
To: dfaure, davidedmundson, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
zzag accepted this revision.
zzag added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> dfaure wrote in test_wayland_surface.cpp:396
> The "Almost Always Auto" crowd would disagree with you, but sure, your
> choice. Done.
Putting auto everywhere is a terrible
dfaure updated this revision to Diff 66290.
dfaure marked 2 inline comments as done.
dfaure added a comment.
Less auto, more range-for, sorting includes
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24014?vs=66276&id=66290
BRANCH
master
REVISION DETAI
dfaure marked 3 inline comments as done.
dfaure added inline comments.
INLINE COMMENTS
> zzag wrote in test_wayland_surface.cpp:396
> I know it's unrelated, but erasing smart pointer types perhaps is not the
> greatest idea. Could you please use concrete type instead of auto while
> you're on t
zzag added inline comments.
INLINE COMMENTS
> test_wayland_surface.cpp:396
>
> -wl_buffer *blackBuffer = *(m_shm->createBuffer(black).data());
> -auto redBuffer = m_shm->createBuffer(red);
> +auto blackBufferPtr = m_shm->createBuffer(black).toStrongRef();
> +QVERIFY(blackBufferP
dfaure created this revision.
dfaure added reviewers: davidedmundson, zzag.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.
TEST PLAN
Builds
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phab
