mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.
REVISION SUMMARY
needed for the context menu entry
TEST PLAN
with the p-w- portion the action shows in the co
ngraham added tasks: T10190: (Re)define modes when editing panels and widgets,
T11094: Improve discoverability of widget configuration, T10402: The Desktop
Toolbox.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D24263
To: mart, #plasma
Cc: kde-frame
ngraham added a dependent revision: D24265: support global edit mode.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D24263
To: mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
ngraham added inline comments.
INLINE COMMENTS
> corona.cpp:406
> +} else {
> +editAction->setText(i18n("Edit Widgets"));
> +}
This isn't just editing editing widgets; maybe "Enter Edit Mode" ? That would
make the name better correspond with the text of the opposite
mart updated this revision to Diff 67051.
mart added a comment.
- always keep the edit action consistent
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24263?vs=66953&id=67051
BRANCH
phab/editModeActionwq!
REVISION DETAIL
https://ph
GB_2 added inline comments.
INLINE COMMENTS
> ngraham wrote in corona.cpp:406
> This isn't just editing editing widgets; maybe "Enter Edit Mode" ? That would
> make the name better correspond with the text of the opposite state too.
>
> Alternatives:
>
> - Edit Layout and Widgets/Freeze Layout
mart added a comment.
the last, "the least the name "edit mode" is user facing, the better it is
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D24263
To: mart, #plasma
Cc: GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns
mart added a comment.
i think in the end
Customize Layout/Finish Customizing Layout
i prefer not to name the term "mode" at all if i can, both because is kinda a
nerdy term and because modes are an ux cardinal sin, so at least not being too
proud of it ;)
REPOSITORY
R242 Plasma Fram
mart updated this revision to Diff 67113.
mart added a comment.
- Customize Layout
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24263?vs=67051&id=67113
BRANCH
phab/editModeActionwq!
REVISION DETAIL
https://phabricator.kde.org/D242
ngraham added a comment.
"Customize Layout" is fine IMO. :)
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D24263
To: mart, #plasma
Cc: GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns
GB_2 added a reviewer: VDG.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D24263
To: mart, #plasma, #vdg
Cc: GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns
GB_2 accepted this revision as: VDG, GB_2.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
phab/editModeActionwq!
REVISION DETAIL
https://phabricator.kde.org/D24263
To: mart, #plasma, #vdg, GB_2
Cc: GB_2, ngraham, kde-frameworks-devel, Le
GB_2 resigned from this revision.
This revision now requires review to proceed.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D24263
To: mart, #plasma, #vdg
Cc: GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns
broulik added inline comments.
INLINE COMMENTS
> corona.cpp:378
> +switch (d->immutability) {
> +case Types::UserImmutable:
> +action->setEnabled(false);
Why is this switch to explicitly stating all the cases?
The action is always visible and enabled only when Mutable
mart updated this revision to Diff 67557.
mart added a comment.
- add parameter to editModeChanged
- hide action on systemimmutable
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24263?vs=67113&id=67557
BRANCH
phab/editModeActionwq!
mart added inline comments.
INLINE COMMENTS
> broulik wrote in corona.cpp:378
> Why is this switch to explicitly stating all the cases?
> The action is always visible and enabled only when Mutable
ah, it wanted to be setVisible(false) in case of systemimmutable, so they
should be all different
ngraham accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
phab/editModeActionwq!
REVISION DETAIL
https://phabricator.kde.org/D24263
To: mart, #plasma, #vdg, ngraham
Cc: broulik, GB_2, ngraham, kde-frameworks-devel, L
GB_2 added inline comments.
INLINE COMMENTS
> corona.cpp:419
> +} else {
> +editAction->setText(i18n("Customize Layout"));
> +}
Missing ellipsis (...)
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
phab/editModeActionwq!
REVISION DETAIL
https://phabricator
mart updated this revision to Diff 67896.
mart added a comment.
- add ellipsis
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24263?vs=67557&id=67896
BRANCH
phab/editModeActionwq!
REVISION DETAIL
https://phabricator.kde.org/D24263
mart marked an inline comment as done.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
phab/editModeActionwq!
REVISION DETAIL
https://phabricator.kde.org/D24263
To: mart, #plasma, #vdg, ngraham
Cc: broulik, GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns
GB_2 added inline comments.
INLINE COMMENTS
> corona.cpp:502
> +});
> +editAction->setText(i18n("Customize Layout"));
> +editAction->setAutoRepeat(true);
Missing ellipsis (...)
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
phab/editModeActionwq!
REVISION DETAIL
https://p
davidedmundson added a comment.
GB_2's comment needs fixing, two strings are out of sync.
Other than that, ship it.
INLINE COMMENTS
> GB_2 wrote in corona.cpp:502
> Missing ellipsis (...)
Given how easy it is to get these out of sync, can I suggest removing all the
code to update editA
mart updated this revision to Diff 68224.
mart added a comment.
- text is always Customize Layout...
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24263?vs=67896&id=68224
BRANCH
phab/editModeActionwq!
REVISION DETAIL
https://phabri
davidedmundson accepted this revision.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
phab/editModeActionwq!
REVISION DETAIL
https://phabricator.kde.org/D24263
To: mart, #plasma, #vdg, ngraham, davidedmundson
Cc: davidedmundson, broulik, GB_2, ngraham, kde-frameworks-devel, LeGast00n,
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:acbb200ac2cc: edit mode action (authored by mart).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D24263?vs=68224&id=68422#toc
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UP
25 matches
Mail list logo
