D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

guoyunhe added a comment. I am not 100% sure. It seems installed under `/etc/xdg/menus/*.menu`. You can install as many *.menu files as you want but keep different names. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24423 To: guoyunhe, #frameworks Cc:

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

ltoscano added a comment. In D24423#594728 , @guoyunhe wrote: > if we copy `applications.menu` to plasma-workspace and patch it there, it will only be shipped with future plasma releases. Isn't it going to conflict with the

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

guoyunhe added a comment. if we copy `applications.menu` to plasma-workspace and patch it there, it will only be shipped with future plasma releases. Existing released plasma can still get the old menu from kservice even with newer frameworks and it is not updated. REPOSITORY R309

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

ltoscano added a comment. In D24423#594718 , @guoyunhe wrote: > Then how about I copy this file `applications.menu` to plasma-workspace? After one or two years, we can delete this file from frameworks. But for compatibility, it will exist in

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

guoyunhe added a comment. Then how about I copy this file `applications.menu` to plasma-workspace? After one or two years, we can delete this file from frameworks. But for compatibility, it will exist in both repositories for some time. REPOSITORY R309 KService REVISION DETAIL

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

ltoscano added a comment. The question is the same. What happens with older Plasma with newer Frameworks? It may be that nothing really breaks, of course. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24423 To: guoyunhe, #frameworks Cc: davidedmundson,

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

guoyunhe added a comment. The dependency D24424 has been landed three month ago. Do you think it is safe to ship this patch now? REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24423 To: guoyunhe, #frameworks Cc:

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

guoyunhe added a comment. I also think these *.menu and *.directory files should not be required at compile time. And they should better be in same repository because they are connected so closely. In this patch, we added a new file `kf5-network.directory` in plasma-workspace and

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

davidedmundson added a comment. > The trouble is still here: if we land this patch and released new frameworks, it won't work with older plasma workspace (like 5.17.0, 5.16.x). Talk me through what will happen. Do they end up in lost and found? In terms of the circular dependency,

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

guoyunhe added a comment. Not sure who should I ping. So I posted in maillist plasma-de...@kde.org REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24423 To: guoyunhe, #frameworks Cc: ngraham, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

ltoscano added a comment. Maybe pinging a few Plasma people may be more effective, or though a mailing list thread. I don't know. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24423 To: guoyunhe, #frameworks Cc: ngraham, ltoscano, kde-frameworks-devel,

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

guoyunhe added a comment. @ngraham @ltoscano should I create bug ticket about the dependency issue we have here? REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24423 To: guoyunhe, #frameworks Cc: ngraham, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

guoyunhe added a comment. `kf5-network.directory` has been added to `plasma-workspace`. The trouble is still here: if we land this patch and released new frameworks, it won't work with older plasma workspace (like 5.17.0, 5.16.x). REPOSITORY R309 KService REVISION DETAIL

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

ngraham added a comment. +1 based on the explanation of following the FDO spec more closely. I'll leave Frameworks folks to figure out how to untangle the implementation details. :) REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24423 To: guoyunhe, #frameworks

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

ltoscano added a comment. I wonder how to untangle this dependency, because a change in Frameworks can't (shouldn't?) depend on a change in a consumer (yes, same issues as toys). REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24423 To: guoyunhe, #frameworks Cc:

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

guoyunhe added a dependency: D24424: Create kf5-network.directory. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24423 To: guoyunhe, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

guoyunhe edited the summary of this revision. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24423 To: guoyunhe, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

guoyunhe added a reviewer: Frameworks. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24423 To: guoyunhe, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

guoyunhe created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. guoyunhe requested review of this revision. REVISION SUMMARY In freedesktop.org specification, the category is Network. Most applications under this category can also be used