D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

This revision was automatically updated to reflect the committed changes. Closed by commit R265:45b6460b0c09: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items (authored by ndavis). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2567

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis marked 2 inline comments as done. REPOSITORY R265 KConfigWidgets BRANCH arcpatch-D25677 (branched from master) REVISION DETAIL https://phabricator.kde.org/D25677 To: ndavis, #frameworks, dfaure Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis updated this revision to Diff 70812. ndavis added a comment. More code formatting REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25677?vs=70802&id=70812 BRANCH arcpatch-D25677 (branched from master) REVISION DETAIL https://phabricator.kd

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kcolorscheme.cpp:289 > struct { > -QBrush fg[8], bg[8], deco[2]; > +QBrush fg[KColorScheme::NForegroundRoles], > bg[KColorScheme::NBackgroundRoles]

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis marked 3 inline comments as done. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25677 To: ndavis, #frameworks, dfaure Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis updated this revision to Diff 70802. ndavis added a comment. - [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items - fix code style REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25677?vs=70720&id=70802 BRANCH arcpatch-D

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. So many hardcoded numbers! Much better indeed. INLINE COMMENTS > kcolorscheme.cpp:88 > > -_effects[0] = 0; > -_effects[1] = 0; > -_effects[2] = 0; > +for(auto &e

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis added a comment. In D25677#570896 , @ngraham wrote: > > This also replaces some for-loops with C++11 range based for-loops and switches for simpler if/else control blocks. > > Seems like these changes are unrelated and should maybe be

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ngraham added a comment. All right. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25677 To: ndavis, #frameworks, dfaure Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ngraham added a comment. > This also replaces some for-loops with C++11 range based for-loops and switches for simpler if/else control blocks. Seems like these changes are unrelated and should maybe be in a separate commit? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://pha

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis added a reviewer: dfaure. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25677 To: ndavis, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis added a reviewer: Frameworks. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25677 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis added a dependency: D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25677 To: ndavis Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY This also replaces some for-loops with C++11 range based for-loops and switches for simpler if/else control blocks. TEST