D27065: Fix inverted logic in IOKitStorage::isRemovable

This revision was automatically updated to reflect the committed changes. Closed by commit R245:d2172d3c0843: Fix inverted logic in IOKitStorage::isRemovable (authored by mwolff). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27065?vs=74772&id=75857 REVISION D

D27065: Fix inverted logic in IOKitStorage::isRemovable

rjvbb accepted this revision. rjvbb added a comment. This revision is now accepted and ready to land. Works fine as far as I can tell, amazing no one else noticed this before! REPOSITORY R245 Solid BRANCH master REVISION DETAIL https://phabricator.kde.org/D27065 To: mwolff, #framework

D27065: Fix inverted logic in IOKitStorage::isRemovable

rjvbb added a subscriber: kde-mac. rjvbb added a comment. Well, I got as far as confirming you're probably right, when I finally got to sit at my Mac yesterday night ... and then when I woke up it was 3am. I'm tempted to green-light this but I think someone is going to have to verify the

D27065: Fix inverted logic in IOKitStorage::isRemovable

rjvbb added a comment. Sorry, no. Swamped with last-minute reconstruction efforts in the, erm, structure that's supposed to become my new house next week :-/ REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D27065 To: mwolff, #frameworks, rjvbb, cgilles Cc: kde-framewor

D27065: Fix inverted logic in IOKitStorage::isRemovable

mwolff added a comment. ping? any update? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D27065 To: mwolff, #frameworks, rjvbb, cgilles Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27065: Fix inverted logic in IOKitStorage::isRemovable

rjvbb added a comment. > This is a MacBook Pro Retina, 13-inch, Mid 2014 with macOS 10.15.2 with only this one disk. It's clearly not supposed to get removed, imo :) Indeed. The icon shown is for internal disks. Thanks for drawing attention to this, I'm going to have to look into t

D27065: Fix inverted logic in IOKitStorage::isRemovable

mwolff added a comment. In D27065#608920 , @rjvbb wrote: > How do you connect? The Mac OS has a built-in VNC server but it has to be activated. Once it is you should be able to connect using any VNC client (possibly using ssh tunnelling?).

D27065: Fix inverted logic in IOKitStorage::isRemovable

rjvbb added a comment. How do you connect? The Mac OS has a built-in VNC server but it has to be activated. Once it is you should be able to connect using any VNC client (possibly using ssh tunnelling?). You can configure the Finder to show every connected volume on the desktop, IIRC it

D27065: Fix inverted logic in IOKitStorage::isRemovable

mwolff added a comment. I now got remote access to a macOS machine. That's where I now got the output from. How do I see all drives in finder? I.e. how could I make the association between the `solid-hardware5` output and finder? REPOSITORY R245 Solid REVISION DETAIL https://phabricator

D27065: Fix inverted logic in IOKitStorage::isRemovable

rjvbb added a comment. > The output comes from running `solid-hardware5 details` and `solid-hardware nonportableinfo` on the UID. That much I got, but on what hardware and with what kind of drive (the summary basically says you don't have a Mac)? Can you add a screenshot of how the dr

D27065: Fix inverted logic in IOKitStorage::isRemovable

mwolff added a comment. In D27065#608818 , @rjvbb wrote: > In D27065#608746 , @mwolff wrote: > > > before: > > > [snip] > > > Note the `Ejectable = false (bool)` vs. `StorageDrive.removable

D27065: Fix inverted logic in IOKitStorage::isRemovable

rjvbb added a reviewer: cgilles. rjvbb added a comment. In D27065#608746 , @mwolff wrote: > before: [snip] > Note the `Ejectable = false (bool)` vs. `StorageDrive.removable = true (bool)`. The patch here fixes it to yield `StorageD

D27065: Fix inverted logic in IOKitStorage::isRemovable

mwolff added a comment. before: udi = 'IOService:/AppleACPIPlatformExpert/PCI0@0/AppleACPIPCI/RP06@1C,5/IOPP/SSD0@0/AppleAHCI/PRT0@0/IOAHCIDevice@0/AppleAHCIDiskDriver/IOAHCIBlockStorageDevice/IOBlockStorageDriver/APPLE SSD SM0256F Media' parent = 'IOService:/AppleACPIPlatformEx

D27065: Fix inverted logic in IOKitStorage::isRemovable

mwolff added a reviewer: rjvbb. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D27065 To: mwolff, #frameworks, rjvbb Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27065: Fix inverted logic in IOKitStorage::isRemovable

mwolff added a reviewer: Frameworks. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D27065 To: mwolff, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27065: Fix inverted logic in IOKitStorage::isRemovable

mwolff created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mwolff requested review of this revision. REVISION SUMMARY Reading through the code, I realized that the isRemovable check returned true when the kDADiskDescriptionDeviceInternalK