D27216: [KProcessRunner] Improve error reported to user when exit code != 0

2020-04-05 Thread David Faure
dfaure added a comment. Oops I totally missed this one, sorry. Does this testcase work better with the new code in kiogui? Hopefully QProcess start should fail? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27216 To: ahmadsamir, #frameworks, dfaure Cc: kde-framew

D27216: [KProcessRunner] Improve error reported to user when exit code != 0

2020-04-04 Thread Ahmad Samir
ahmadsamir abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27216 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27216: [KProcessRunner] Improve error reported to user when exit code != 0

2020-02-09 Thread Ahmad Samir
ahmadsamir requested review of this revision. ahmadsamir added a comment. krununittest fails to pass, I tried to debug it but can't get it to work. Disabling the third row "QTest::newRow("tempfile") << true << false;" in KRunUnitTest::KRunRunService_data, makes it pass... I can't figure it ou

D27216: [KProcessRunner] Improve error reported to user when exit code != 0

2020-02-07 Thread Ahmad Samir
ahmadsamir planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27216 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27216: [KProcessRunner] Improve error reported to user when exit code != 0

2020-02-07 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY When a process that KRun tried to run fails to launch: - Tell the user when the executable could not be found