D27372: smb: disable mode bits getting forwarded to KIO

2020-02-14 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R320:718abcb69b78: smb: disable mode bits getting forwarded to KIO (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27372?vs=75618=75704

D27372: smb: disable mode bits getting forwarded to KIO

2020-02-13 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice, this fixes the bug for me and I think the code change makes logical sense. I really appreciate these long comments. REPOSITORY R320 KIO Extras BRANCH bug414482 REVISION

D27372: smb: disable mode bits getting forwarded to KIO

2020-02-13 Thread Harald Sitter
sitter added a subscriber: dfaure. sitter added a comment. @dfaure btw, it seems you cannot have no ACL displayed. i.e. properties dialog does `d->hasExtendedACL = item.ACL().isExtended() || item.defaultACL().isValid();` but isExtended is even true for invalid ACLs, so in the smb scenario I

D27372: smb: disable mode bits getting forwarded to KIO

2020-02-13 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY mode bits in libsmb_stat are fairly cheaply constructed. file and