D28590: Add a QString Solid::Device::label, used in Fstab Device for network mounts

meven created this revision. meven added reviewers: Frameworks, bruns, sitter. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY This adds a label field, so that devices can provide a label and a more d

D28590: Add a QString Solid::Device::label, used in Fstab Device for network mounts

bruns added a comment. I think it would be better to not change behaviour for any backend, but just default label() to description() everywhere. Then in the next step, adjust description() and label() for each backend, shorten label where possible, and extend description() so it becomes

D28590: Add a QString Solid::Device::label, used in Fstab Device for network mounts

bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28590 To: meven, #frameworks, bruns, sitter Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28590: Add a QString Solid::Device::label, used in Fstab Device for network mounts

bruns added a comment. Btw, label() is a bad name, it can be confused with the filesystem label to easily. Maybe shortName(). REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28590 To: meven, #frameworks, bruns, sitter Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D28590: Add a QString Solid::Device::label, used in Fstab Device for network mounts

meven marked an inline comment as done. meven added a comment. In D28590#642133 , @bruns wrote: > Btw, label() is a bad name, it can be confused with the filesystem label to easily. Maybe shortName(). I meant to reuse this name on purpose

D28590: Add a QString Solid::Device::label, used in Fstab Device for network mounts

meven updated this revision to Diff 79807. meven marked 2 inline comments as done. meven added a comment. Rename label to displayName REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28590?vs=79397&id=79807 BRANCH master REVISION DETAIL https://phabricato