This revision was automatically updated to reflect the committed changes.
Closed by commit R241:ae0beded1fd9: Show previews on encrypted filesystems
(authored by marcingu, committed by ngraham).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28746?vs=80022=80024
ngraham added a comment.
Excellent job. This is a real improvement. Keep the great patches coming! :)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D28746
To: marcingu, ivan, #frameworks, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh,
ngraham edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D28746
To: marcingu, ivan, #frameworks, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
ivan accepted this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D28746
To: marcingu, ivan, #frameworks, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
marcingu marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D28746
To: marcingu, ivan, #frameworks, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
marcingu updated this revision to Diff 80022.
marcingu added a comment.
Removing extra whitespaces
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28746?vs=79991=80022
REVISION DETAIL
https://phabricator.kde.org/D28746
AFFECTED FILES
ngraham added inline comments.
INLINE COMMENTS
> ngraham wrote in previewjob.cpp:718
> unrelated change
Now there are extra spaces on that line. :)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D28746
To: marcingu, ivan, #frameworks, dfaure, ngraham
Cc: ngraham,
marcingu marked 2 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D28746
To: marcingu, ivan, #frameworks, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
marcingu updated this revision to Diff 79991.
marcingu added a comment.
Moving boolean variables to the front of logic statement.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28746?vs=79985=79991
REVISION DETAIL
https://phabricator.kde.org/D28746
dfaure added inline comments.
INLINE COMMENTS
> previewjob.cpp:307
>
> +//Prepare encryptedMountsList for which will be used in ::slotThumbData
> const auto mountsList = KMountPoint::currentMountPoints();
"for which will be used" ... remove `for` ?
REPOSITORY
R241 KIO
REVISION
ivan added inline comments.
INLINE COMMENTS
> previewjob.cpp:697
>
> !currentItem.item.url().adjusted(QUrl::RemoveFilename).toLocalFile().startsWith(thumbRoot))
> -&& !sequenceIndex;
> +&& !sequenceIndex && !isEncrypted;
> QImage thumb;
marcingu marked 2 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D28746
To: marcingu, ivan, #frameworks, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
marcingu updated this revision to Diff 79985.
marcingu added a comment.
Review fixes
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28746?vs=79832=79985
REVISION DETAIL
https://phabricator.kde.org/D28746
AFFECTED FILES
src/widgets/previewjob.cpp
To:
ivan added inline comments.
INLINE COMMENTS
> previewjob.cpp:692
> {
> +bool isEncrypted =
> encryptedMountsList.findByPath(currentItem.item.url().toLocalFile());
> bool save = bSave &&
`const`
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D28746
To:
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Works and looks good to me modulo one comment, but let's wait for the other
reviewers too.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D28746
To: marcingu,
ngraham added reviewers: ivan, Frameworks, dfaure.
ngraham added a comment.
General idea looks sane to me. Thanks for working on this; it's been one of
those minor annoyances of mine.
INLINE COMMENTS
> previewjob.cpp:718
> }
> -
> if (save) {
unrelated change
REPOSITORY
R241
marcingu added a dependent revision: D28745: Skipping catching of thumbnails on
encrytped filesystems.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D28746
To: marcingu
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
marcingu created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
marcingu requested review of this revision.
REVISION SUMMARY
Instead of skipping generating previews on encrypted filesystems, do create
them but don't cache.
BUG: 411919
18 matches
Mail list logo
