D29461: Fix kio-extras build on Windows

2020-05-27 Thread Piyush Aggarwal
brute4s99 closed this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29461 To: brute4s99, vonreth, meven Cc: sitter, meven, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas

D29461: Fix kio-extras build on Windows

2020-05-26 Thread Méven Car
meven accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH arcpatch-D29461 REVISION DETAIL https://phabricator.kde.org/D29461 To: brute4s99, vonreth, meven Cc: sitter, meven, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolai

D29461: Fix kio-extras build on Windows

2020-05-26 Thread Piyush Aggarwal
brute4s99 added a comment. updated libssh to use version 0.9.4 by default in Craft. We can merge this and get 🟢 for kio-extras builds. \o/ REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29461 To: brute4s99, vonreth, meven Cc: sitter, meven, kde-frameworks-devel,

D29461: Fix kio-extras build on Windows

2020-05-26 Thread Piyush Aggarwal
brute4s99 marked an inline comment as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29461 To: brute4s99, vonreth, meven Cc: sitter, meven, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack,

D29461: Fix kio-extras build on Windows

2020-05-26 Thread Piyush Aggarwal
brute4s99 marked 3 inline comments as done. brute4s99 added inline comments. INLINE COMMENTS > vonreth wrote in CMakeLists.txt:26 > yes pls update libssh Hi! Sorry, I got around to this patch quite late. I added a new patch for 0.9.4 release as parent revision to this revision, please take a lo

D29461: Fix kio-extras build on Windows

2020-05-26 Thread Piyush Aggarwal
brute4s99 added a dependency: D29835: Add libssh 0.9.4 to fix kio-extras on windows. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29461 To: brute4s99, vonreth, meven Cc: sitter, meven, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasen

D29461: Fix kio-extras build on Windows

2020-05-26 Thread Piyush Aggarwal
brute4s99 updated this revision to Diff 83159. REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29461?vs=82069&id=83159 BRANCH arcpatch-D29461 REVISION DETAIL https://phabricator.kde.org/D29461 AFFECTED FILES sftp/CMakeLists.txt sftp/kio_sftp.cpp T

D29461: Fix kio-extras build on Windows

2020-05-06 Thread Hannah von Reth
vonreth added inline comments. INLINE COMMENTS > brute4s99 wrote in CMakeLists.txt:26 > I just built libssh 0.9.4, and kio-extras builds fine without this line > change. Maybe we should try getting latest libssh onboard. Can I help in that > somehow @vonreth ? yes pls update libssh REPOSITORY

D29461: Fix kio-extras build on Windows

2020-05-06 Thread Piyush Aggarwal
brute4s99 added inline comments. INLINE COMMENTS > sitter wrote in CMakeLists.txt:26 > Hm, I am a bit hazy on the details but I think this changes makes no sense. > libssh (upstream) introduced an imported target `ssh`. For backwards > compatibility we also inject this target when building with

D29461: Fix kio-extras build on Windows

2020-05-06 Thread Harald Sitter
sitter added a comment. Pid changes look fine, though perhaps we should just throw those two lines away? With Qt5 logging the pid is fairly pointless because one can simply set QT_MESSAGE_PATTERN to include the pid when necessary https://doc.qt.io/qt-5/qtglobal.html#qSetMessagePattern INLIN

D29461: Fix kio-extras build on Windows

2020-05-06 Thread Piyush Aggarwal
brute4s99 added a subscriber: sitter. brute4s99 added a comment. @sitter could you please review this change as well? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29461 To: brute4s99, vonreth, meven Cc: sitter, meven, kde-frameworks-devel, kfm-devel, azyx, niko

D29461: Fix kio-extras build on Windows

2020-05-06 Thread Piyush Aggarwal
brute4s99 updated this revision to Diff 82069. brute4s99 added a comment. updated the diff REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29461?vs=82039&id=82069 BRANCH arcpatch-D29461 REVISION DETAIL https://phabricator.kde.org/D29461 AFFECTED FI

D29461: Fix kio-extras build on Windows

2020-05-05 Thread Méven Car
meven requested changes to this revision. meven added a comment. This revision now requires changes to proceed. We have : kio-extras/cmake/Findlibssh.cmake To do that. I don't think copy/pasting code to `sftp/CMakeLists.txt` is necessary. REPOSITORY R320 KIO Extras REVISION DETAIL

D29461: Fix kio-extras build on Windows

2020-05-05 Thread Piyush Aggarwal
brute4s99 updated this revision to Diff 82039. brute4s99 added a comment. needs testing on windows, will update in a while REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29461?vs=82036&id=82039 BRANCH arcpatch-D29461 REVISION DETAIL https://phabric

D29461: Fix kio-extras build on Windows

2020-05-05 Thread Piyush Aggarwal
brute4s99 created this revision. brute4s99 added a reviewer: vonreth. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. brute4s99 requested review of this revision. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabric