dfaure closed this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D29547
To: dfaure, ahmadsamir, broulik, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
ahmadsamir accepted this revision.
ahmadsamir added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> dfaure wrote in krun.h:216
> I did, but Friedrich had a less confusing suggestion:
>
> @deprecated since 5.6. Since 5.71 use ApplicationLauncherJob, otherwise
dfaure updated this revision to Diff 82453.
dfaure marked 2 inline comments as done.
dfaure added a comment.
take review into account
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29547?vs=82325=82453
BRANCH
2020_05_deprecate_KRun_run_methods
REVISION
dfaure marked 2 inline comments as done.
dfaure added inline comments.
INLINE COMMENTS
> ahmadsamir wrote in krun.h:216
> I don't think you want both @deprecated?
I did, but Friedrich had a less confusing suggestion:
@deprecated since 5.6. Since 5.71 use ApplicationLauncherJob, otherwise
ahmadsamir added inline comments.
INLINE COMMENTS
> krun.h:216
> + * @deprecated since 5.6, use runApplication instead.
> + * @deprecated since 5.71, use ApplicationLauncherJob instead.
> + * @code
I don't think you want both @deprecated?
> krun.h:229
> */
> -
dfaure added a reviewer: svuorela.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D29547
To: dfaure, ahmadsamir, broulik, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
dfaure added a dependent revision: D29557: Add
KIO::OpenUrlJob::setShowOpenWithDialog as replacement for
KRun::displayOpenWithDialog.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D29547
To: dfaure, ahmadsamir, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack,
dfaure created this revision.
dfaure added reviewers: ahmadsamir, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.
REVISION SUMMARY
[Next up, KRun::displayOpenWithDialog]
REPOSITORY
R241 KIO
BRANCH
