aacid added a comment.
So if i have two okular open, how do i access the second via dbus?
REPOSITORY
R271 KDBusAddons
REVISION DETAIL
https://phabricator.kde.org/D5775
To: apol, #frameworks, jgrulich, aacid
Cc: dfaure, davidedmundson, aacid
apol marked 2 inline comments as done.
REPOSITORY
R271 KDBusAddons
REVISION DETAIL
https://phabricator.kde.org/D5775
To: apol, #frameworks, jgrulich, aacid
Cc: dfaure, davidedmundson, aacid
dfaure added inline comments.
INLINE COMMENTS
> kdbusservice.cpp:98
> +bool inSandbox = false;
> +if (!qEnvironmentVariableIsEmpty("XDG_RUNTIME_DIR")) {
> +const QByteArray runtimeDir = qgetenv("XDG_RUNTIME_DIR");
this if() seems useless (double lookup).
This revision was automatically updated to reflect the committed changes.
Closed by commit R271:8b79a5374afc: Don't include the pid in the dbus path when
on flatpak (authored by apol).
REPOSITORY
R271 KDBusAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5775?vs=14782=14825
aacid accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R271 KDBusAddons
BRANCH
arcpatch-D5775
REVISION DETAIL
https://phabricator.kde.org/D5775
To: apol, #frameworks, jgrulich, aacid
Cc: dfaure, davidedmundson, aacid
apol updated this revision to Diff 14782.
apol added a comment.
Keep the old reverse.domain-pid notation when not sandboxed
REPOSITORY
R271 KDBusAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5775?vs=14642=14782
BRANCH
arcpatch-D5775
REVISION DETAIL
aacid added a comment.
.kdbus
In https://phabricator.kde.org/D5775#111234, @apol wrote:
> In https://phabricator.kde.org/D5775#111230, @aacid wrote:
>
> > maybe not change the serviceName if not using flatpack?
>
>
> We are not changing it, that's why we do the inSandbox
apol added a comment.
In https://phabricator.kde.org/D5775#111230, @aacid wrote:
> maybe not change the serviceName if not using flatpack?
We are not changing it, that's why we do the inSandbox bit.
REPOSITORY
R271 KDBusAddons
REVISION DETAIL
aacid added a comment.
In https://phabricator.kde.org/D5775#111218, @apol wrote:
> Can somebody point out a problem with this approach? Or approve instead?
> If nobody does I'll just push the patch.
maybe not change the serviceName if not using flatpack?
REPOSITORY
R271
apol added a comment.
Can somebody point out a problem with this approach? Or approve instead?
If nobody does I'll just push the patch.
REPOSITORY
R271 KDBusAddons
REVISION DETAIL
https://phabricator.kde.org/D5775
To: apol, #frameworks, jgrulich
Cc: dfaure, davidedmundson, aacid
jgrulich added a comment.
In https://phabricator.kde.org/D5775#110551, @apol wrote:
> In https://phabricator.kde.org/D5775#110530, @jgrulich wrote:
>
> > In https://phabricator.kde.org/D5775#110529, @jgrulich wrote:
> >
> > > +1
> > >
> > > good idea, it should solve all the
apol added a comment.
In https://phabricator.kde.org/D5775#110530, @jgrulich wrote:
> In https://phabricator.kde.org/D5775#110529, @jgrulich wrote:
>
> > +1
> >
> > good idea, it should solve all the problems, we should use similar
approach in KNotifications for SNI support.
>
jgrulich added a comment.
In https://phabricator.kde.org/D5775#110529, @jgrulich wrote:
> +1
>
> good idea, it should solve all the problems, we should use similar approach
in KNotifications for SNI support.
Actually this won't work for KNotifications and SNI, still problem
jgrulich added a comment.
+1
good idea, it should solve all the problems, we should use similar approach
in KNotifications for SNI support.
REPOSITORY
R271 KDBusAddons
REVISION DETAIL
https://phabricator.kde.org/D5775
To: apol, #frameworks, jgrulich
Cc: dfaure, davidedmundson,
apol updated this revision to Diff 14642.
apol added a comment.
Fix reverse domain notation
REPOSITORY
R271 KDBusAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5775?vs=14541=14642
BRANCH
arcpatch-D5775
REVISION DETAIL
https://phabricator.kde.org/D5775
AFFECTED FILES
jgrulich added a comment.
I think this still doesn't solve the general problem we have with sandboxed
applications as you cannot still allow this dbus service in app manifest. You
can use "org.kde.AppName.*" , but then the dbus name would need to be in form
of "org.kde.AppName.appPid" or
apol updated this revision to Diff 14541.
apol added a comment.
Fix regression
REPOSITORY
R271 KDBusAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5775?vs=14301=14541
BRANCH
arcpatch-D5775
REVISION DETAIL
https://phabricator.kde.org/D5775
AFFECTED FILES
dfaure added a comment.
d_ed: I use the DBus name in multi mode to talk to running processes ;-)
(for introspection, debugging, automation, etc.)
REPOSITORY
R271 KDBusAddons
REVISION DETAIL
https://phabricator.kde.org/D5775
To: apol, #frameworks, jgrulich
Cc: dfaure,
davidedmundson added a comment.
Alternate suggestion:
register app-name + QDbus::connection()->baseServiceName.
it'll be guaranteed unique.
(though does anything even use the DBus service name in multi mode? It
doesn't seem to be very useful. kquitapp5 doesn't support it.)
apol added a comment.
In https://phabricator.kde.org/D5775#108938, @jgrulich wrote:
> Problem is that the name, even when the pid would be unique, won't be
predictable. You still need to change it to something like org.kde.appName.pid
so you can use org.kde.appName.* in flatpak
jgrulich added a comment.
In https://phabricator.kde.org/D5775#108825, @apol wrote:
> In https://phabricator.kde.org/D5775#108649, @jgrulich wrote:
>
> > In https://phabricator.kde.org/D5775#108558, @aacid wrote:
> >
> > > I don't think this is a fix.
> > >
> > > I can't
apol added a comment.
In https://phabricator.kde.org/D5775#108649, @jgrulich wrote:
> In https://phabricator.kde.org/D5775#108558, @aacid wrote:
>
> > I don't think this is a fix.
> >
> > I can't really i good faith recommend people to use Okular from a flatpak
if that means they
aacid added a comment.
I don't think this is a fix.
I can't really i good faith recommend people to use Okular from a flatpak if
that means they can't start two okular instances.
REPOSITORY
R271 KDBusAddons
REVISION DETAIL
https://phabricator.kde.org/D5775
To: apol, #frameworks,
apol added a comment.
In https://phabricator.kde.org/D5775#108315, @aacid wrote:
> This means we get the same path if we start the process twice, does it
still work? Don't you get some kind of collision at the dbus level?
Yes, with this patch you can only open 1 of the
aacid added a comment.
This means we get the same path if we start the process twice, does it still
work? Don't you get some kind of collision at the dbus level?
REPOSITORY
R271 KDBusAddons
REVISION DETAIL
https://phabricator.kde.org/D5775
To: apol, #frameworks, jgrulich
Cc: aacid
jgrulich added a comment.
Looks good, it really doesn't make sense to use pid when running app in
flatpak, because you cannot guarantee what pid it will get and without that you
cannot allow dbus access in app's flatpak manifest.
REPOSITORY
R271 KDBusAddons
REVISION DETAIL
apol edited the test plan for this revision.
REPOSITORY
R271 KDBusAddons
REVISION DETAIL
https://phabricator.kde.org/D5775
To: apol, #frameworks, jgrulich
apol created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Flatpak requests us to list the services that will be exposed to the outside,
better have it the name of the application without a random number in the end.
In these systems the pid doesn't add
28 matches
Mail list logo
