rjvbb created this revision.
rjvbb added a project: Frameworks.
REVISION SUMMARY
This clarifies a few details about icons and icon themes on Mac and MS
Windows, calling attention to the fact that icon themes can be available as
usual and that embedded icon resources are thus not the only way a
tfry added a comment.
It's difficult to explain a confusing situation, clearly, but I don't think
you succeeded. AFAIU, there are //three// distinct approaches:
a) embedded icons
b) QIcon::setThemeSearchPaths()
c) patched libs
From the current wording I'm not sure, whether you do or
rjvbb updated this revision to Diff 15688.
rjvbb added a comment.
To be honest I didn't even think of patched libs, certainly not Qt itself.
What I *can* think of is a platform theme plugin like the one from
plasma-integration, which can serve a comparable purpose (including making the
the c
rjvbb set the repository for this revision to R302 KIconThemes.
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D6309
To: rjvbb, #frameworks
Cc: tfry, kde-mac, #frameworks
tfry added a comment.
Much clearer, now, IMO.
Your osx-integration plugin is what I was thinking of, when writing about
"patched libs". See, that's how confused I am, I just can't seem to remember
any of this...
How about adding that detail, too, e.g.:
... provided that the l
rjvbb updated this revision to Diff 15694.
rjvbb added a comment.
In fact any kind of plugin can do this that is loaded sufficiently early, or
even an initialisation procedure in an additional library you link with (but
that is maybe TMI and somewhat self-evident). I don't mind propaganda for
rjvbb set the repository for this revision to R302 KIconThemes.
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D6309
To: rjvbb, #frameworks
Cc: tfry, kde-mac, #frameworks
tfry added a comment.
Looks good to me.
This place is talking about how to get icon themes working, and so it should
list the most relevant approaches. Arguably, this is not the place where I
would have looked for an answer to that question, first, but since it does
provide an answer, i
rjvbb added a comment.
Well, somehow this wasn't closed automatically:
https://commits.kde.org/kiconthemes/ac5cbf6b4aa969542a780077213cb39a4c110fe6
> Arguably, this is not the place where I would have looked for an answer to
that question, first, but since it does provide an answer, it
This revision was automatically updated to reflect the committed changes.
Closed by commit R302:ac5cbf6b4aa9: More details about deploying icon themes on
Mac & MSWin (authored by rjvbb).
REPOSITORY
R302 KIconThemes
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6309?vs=15694&id=15775
bcooksley added a comment.
As Phabricator does not host the repositories it polls them periodically
based on activity in the repository. For KIconThemes this is about once an hour.
The system has now polled the repository and the hook has correspondingly
been triggered.
REPOSITORY
R302 K
rjvbb added a comment.
Ben Cooksley wrote on 20170623::09:17:33 re:
"https://phabricator.kde.org/D6309: KIconThemes: some additional details about
themes & icons on Mac & MSWin"
> The system has now polled the repository and the hook has correspondingly
been
bcooksley added a comment.
All the tooling and functionality i've described is provided by Phabricator
itself. We don't have any control over that (without codebase changes, which
i'm strongly against due to the speed of development of Phabricator)
REPOSITORY
R302 KIconThemes
REVISION DET
13 matches
Mail list logo
