mwolff created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
When a KComboBox was created and a completion object configured on
it, that setting was lost once the combo box was set to be editable.
To
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Just to be sure, your unittest could also test the case of setEditable(false).
REPOSITORY
R284 KCompletion
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7966
To: mwolff
This revision was automatically updated to reflect the committed changes.
Closed by commit R284:cf2f5c72d9f3: KComboBox: Reuse the existing completion
object on new line edit (authored by mwolff).
REPOSITORY
R284 KCompletion
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7966?vs=1985
mwolff added a comment.
In https://phabricator.kde.org/D7966#148641, @dfaure wrote:
> Just to be sure, your unittest could also test the case of
setEditable(false).
What should it test then? if it's not editable, there is no line edit, and
thus no completion object?
REPOSITORY
