smithjd retitled this revision from "Strip down and re-write the tags KIO
slave." to "Strip down and re-write the baloo tags KIO slave".
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D8098
To: smithjd, #frameworks, vhanda, #dolphin, ngraham, dfaure
Cc: dfaure, nicolasfel
smithjd updated this revision to Diff 22712.
smithjd added a comment.
Make work with kioclient.
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8098?vs=22107&id=22712
BRANCH
master-nestedTags (branched from master)
REVISION DETAIL
https://phabricator.kde
smithjd marked 2 inline comments as done.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D8098
To: smithjd, #frameworks, vhanda, #dolphin, ngraham, dfaure
Cc: dfaure, nicolasfella, ngraham
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> dfaure wrote in kio_tags.cpp:119
> missing KIO::Overwrite support? Can the dest already exist?
I see an added check for "already exists" and an early return (
smithjd updated this revision to Diff 22792.
smithjd marked 6 inline comments as done.
smithjd added a comment.
- Review changes.
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8098?vs=22712&id=22792
BRANCH
master-nestedTags (branched from master)
REVISIO
smithjd added inline comments.
INLINE COMMENTS
> dfaure wrote in kio_tags.cpp:119
> I see an added check for "already exists" and an early return (good), but no
> support for KIO::Overwrite. If the user uses dolphin to copy a tag they might
> click on "overwrite" and it won't work, if copy() ju
anthonyfieroni added inline comments.
INLINE COMMENTS
> kio_tags.cpp:363
> +
> +if (result.decodedUrl.contains(QStringLiteral("?//")) ||
> chopLastSection) {
> +result.tag = result.tag.section(QDir::separator(), 0, -2);
Better reverse conditions
if (chopLastSection ||...)
smithjd updated this revision to Diff 22857.
smithjd marked 3 inline comments as done.
smithjd added a comment.
- Review suggestions.
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8098?vs=22792&id=22857
BRANCH
master-nestedTags (branched from master)
REV
smithjd added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in kio_tags.h:101
> metaData(QString{})
Doesn't work.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D8098
To: smithjd, #frameworks, vhanda, #dolphin, ngraham, dfaure
Cc: anthonyfieroni, dfaure, nicol
smithjd updated this revision to Diff 22938.
smithjd added a comment.
- Fix valid tag calculation.
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8098?vs=22857&id=22938
BRANCH
master-nestedTags (branched from master)
REVISION DETAIL
https://phabricator.
smithjd added a comment.
Currently known issues:
Entering a tagged folder works, listing it from within the tags: protocol in
the slave results in a folder cannot be entered error. Attempting to copy a tag
tree with such a populated folder results in a file not found error for each
file
smithjd updated this revision to Diff 22940.
smithjd added a comment.
- Fix for slash-less tag urls.
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8098?vs=22938&id=22940
BRANCH
master-nestedTags (branched from master)
REVISION DETAIL
https://phabricato
smithjd updated this revision to Diff 23101.
smithjd added a comment.
- Fix tagged directory listing.
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8098?vs=22940&id=23101
BRANCH
master-nestedTags (branched from master)
REVISION DETAIL
https://phabricat
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R293 Baloo
BRANCH
master-nestedTags (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D8098
To: smithjd, #frameworks, vhanda, #dolphin, ngraham, dfaure
Cc: anthonyfieroni, dfaure, n
ngraham added a comment.
Excellent! @smithjd, is this ready to go in now, or are you still making more
changes?
REPOSITORY
R293 Baloo
BRANCH
master-nestedTags (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D8098
To: smithjd, #frameworks, vhanda, #dolphin, ngraham,
smithjd updated this revision to Diff 23146.
smithjd added a comment.
- Fix generating previews copies the file to tmp.
- Fix tag navigation display labels in Dolphin.
- Stricter url validation.
- Create a full url instead of only a path.
- Check if the destination file already has the
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:16664fccb7b7: Strip down and re-write the baloo tags KIO
slave (authored by smithjd).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8098?vs=23146&id=23147#toc
REPOSITORY
R293 Baloo
CHANGES
smithjd added a comment.
In https://phabricator.kde.org/D8098#173418, @ngraham wrote:
> Excellent! @smithjd, is this ready to go in now, or are you still making
more changes?
There are still known problems with tagged directory copies. Overall however
it's in a pretty good state
18 matches
Mail list logo
