D8296: Use Ctrl+Shift+, as the standard shortcut for "Configure "

ngraham added a comment. @rkflx I'm looking into it now. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik, rkflx Cc: ilic, abetts, elvisangelaccio, aacid, argonel, marten, graesslin, broulik, #frameworks, michaelh

D8296: Use Ctrl+Shift+, as the standard shortcut for "Configure "

rkflx added a comment. @ngraham Is (K)ubuntu 18.04 really going to ship Digikam 5.6 from June 2017, i.e. creating an influx of bug reports on shortcut warnings? Can this be patched in either Digikam or KF5 packages? REPOSITORY R237 KConfig REVISION DETAIL

D8296: Use Ctrl+Shift+, as the standard shortcut for "Configure "

ngraham added a comment. Landed now that Digikam 5.8.0 has been released, and updated the wiki: https://community.kde.org/KDE_Visual_Design_Group/HIG/Keyboard_Shortcuts REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik,

D8296: Use Ctrl+Shift+, as the standard shortcut for "Configure "

This revision was automatically updated to reflect the committed changes. Closed by commit R237:cd25475f8723: Use Ctrl+Shift+, as the standard shortcut for Configure Program (authored by ngraham). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D8296: Use Ctrl+Shift+, as the standard shortcut for "Configure "

ngraham added a comment. Looks like DigiKam 5.8.0 is supposed to be released in two days: https://staging.digikam.org/news/2018-01-14-5.8.0_release_announcement/ Once it's released, I'll land this. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL

D8296: Use Ctrl+Shift+, as the standard shortcut for "Configure "

rkflx added a comment. In https://phabricator.kde.org/D8296#162352, @rkflx wrote: > As mentioned in the bug, we should wait until after digiKam has had a release containing the change, i.e. 5.8.0. Provoking the dreaded shortcut warning dialog would be a bad way to say "thank you".

D8296: Use Ctrl+Shift+, as the standard shortcut for "Configure "

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik, rkflx Cc: ilic, abetts, elvisangelaccio, aacid, argonel, marten,

D8296: Use Ctrl+Shift+, as the standard shortcut for "Configure "

ngraham added a comment. Makes sense! REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik, rkflx Cc: ilic, abetts, elvisangelaccio, aacid, argonel, marten, graesslin, broulik, #frameworks

D8296: Use Ctrl+Shift+, as the standard shortcut for "Configure "

rkflx accepted this revision. rkflx added a comment. This revision is now accepted and ready to land. As mentioned in the bug, we should wait until after digiKam has had a release containing the change, i.e. 5.8.0. Provoking the dreaded shortcut warning dialog would be a bad way to say

D8296: Use Ctrl+Shift+, as the standard shortcut for "Configure "

ngraham added a comment. The DigiKam folks changed the shortcut, so we can use Ctrl+Shift+, now! Any remaining objections? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik, rkflx Cc: ilic, abetts, elvisangelaccio, aacid,

D8296: Use Ctrl+Shift+, as the standard shortcut for "Configure "

ngraham edited the test plan for this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik, rkflx Cc: ilic, abetts, elvisangelaccio, aacid, argonel, marten, graesslin, broulik, #frameworks

D8296: Use Ctrl+Shift+, as the standard shortcut for "Configure "

ngraham retitled this revision from "Use Ctrl+Shift+. as the standard shortcut for "Configure "" to "Use Ctrl+Shift+, as the standard shortcut for "Configure "". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R237 KConfig REVISION

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

ngraham updated this revision to Diff 21542. ngraham added a comment. Ctrl+Shift+Comma FTW REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8296?vs=21531=21542 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8296 AFFECTED FILES

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

ngraham added a comment. In https://phabricator.kde.org/D8296#161574, @rkflx wrote: > In https://phabricator.kde.org/D8296#161570, @rkflx wrote: > > > Possibly the conflict detection is broken? > > > Turns out it's not, the shortcut is actually defined for the "Light Table".

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

ilic added a comment. `KStandardShortcut::Preferences` label is being overridden in KConfigWidgets's `src/kstandardaction_p.h` to `" %1..."` and %1 substituted with current application name. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham,

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

rkflx added a comment. In https://phabricator.kde.org/D8296#161570, @rkflx wrote: > Possibly the conflict detection is broken? Turns out it's not, the shortcut is actually defined for the "Light Table". However, there the shortcut is listed twice and works the same (for me at

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

rkflx added a comment. In https://phabricator.kde.org/D8296#161566, @ngraham wrote: > Digikam, which is as far as I can tell the only one using Ctrl+Shift+, Is it, though? I don't see it here: F5456767: digikam.png There might actually

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

ngraham added a comment. @rkflx If we need to change one app, we could also target Digikam, which is as far as I can tell the only one using Ctrl+Shift+, @ilic Actually the problem is that this string--whatever it is in the code--is being changed for English to "Configure System

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

ilic added a comment. "Configure Application" does sound better than "Preferences", but that's just my opinion as a random translator, no link to my i18n plumber's hat :) REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik,

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

ngraham planned changes to this revision. ngraham added a comment. Urgh, didn't find it because it's defined in Konsole like this: `Konsole::ACCEL + Qt::SHIFT + Qt::Key_Period` REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg,

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

rkflx added a comment. In https://phabricator.kde.org/D8296#161557, @rkflx wrote: > Let's hope nobody finds any obscure place where this is used already... Hm, conflicts in Konsole. However, can we change Konsole? At least, you could use this to improve your lxr search, so maybe

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

rkflx added a subscriber: ilic. rkflx added a comment. Was confused and it took me a while to figure out how this will end up for different keyboard layouts. Turns out using the KCM combines [⇧] + [key], while `arc patch` results in all three keys shown in the menu. This means that [.]

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

ngraham added a comment. So as for changing the name... I notice that this uses `QT_TRANSLATE_NOOP3()` instead of `i18n`. It seems that the English string at least is simply a bad translation, likely caused by the poorly-chosen base string, which I've changed to be a bit more descriptive.

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

ngraham updated this revision to Diff 21531. ngraham added a comment. Improved translation string to provide a better hint about what this really is REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8296?vs=21530=21531 BRANCH master REVISION DETAIL

D8296: Use Ctrl+Shift+. as the standard shortcut for "Configure "

ngraham retitled this revision from "Use Ctrl+Alt+, as the standard shortcut for "Configure "" to "Use Ctrl+Shift+. as the standard shortcut for "Configure "". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R237 KConfig REVISION DETAIL