This revision was automatically updated to reflect the committed changes.
Closed by commit R824:38681e7d27f5: Show Date Modified information by default
in Dolphin's Information Panel and… (authored by ngraham).
REPOSITORY
R824 Baloo Widgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.o
ngraham added a comment.
Great, thank you!
REPOSITORY
R824 Baloo Widgets
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8303
To: ngraham, #dolphin, #kde_applications, #frameworks, aacid, markg
Cc: markg, elvisangelaccio, anthonyfieroni, spoorun, navarromorales, firef,
ngr
markg accepted this revision.
markg added a comment.
This revision is now accepted and ready to land.
In https://phabricator.kde.org/D8303#155858, @ngraham wrote:
> Honestly I think it's fine the way it is: in the details view, we have a
nice compact string that doesn't make the column to
ngraham added a comment.
Honestly I think it's fine the way it is: in the details view, we have a nice
compact string that doesn't make the column too wide, and in the Information
Panel, we have a longer string that provides more information and isn't too big
since text can wrap there.
markg added a comment.
In https://phabricator.kde.org/D8303#155840, @ngraham wrote:
> @markg I actually like the current verbose format. That's somewhat
unrelated to this; can we track that change, if any, with a new patch?
That depends on how you want to do that ;)
What i'm
ngraham marked an inline comment as done.
ngraham added a comment.
@markg I actually like the current verbose format. That's somewhat unrelated
to this; can we track that change, if any, with a new patch?
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D8303
To
markg requested changes to this revision.
markg added a comment.
This revision now requires changes to proceed.
+1 for having this property
-1 for the current rather verbose date format. Look at the "Modified" column
in the any dolphin details view. It (on my setup) just shows a date and a H
elvisangelaccio added a comment.
I guess +1 from me. Infopanel and tooltips are disabled by default anyway, so
it's not a big deal if we also show the mtime there.
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D8303
To: ngraham, #dolphin, #kde_applications, #
ngraham added a reviewer: aacid.
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D8303
To: ngraham, #dolphin, #kde_applications, #frameworks, aacid
Cc: anthonyfieroni, spoorun, navarromorales, firef, ngraham, andrebarros,
emmanuelp
ngraham updated this revision to Diff 20768.
ngraham added a comment.
Update current version
REPOSITORY
R824 Baloo Widgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8303?vs=20767&id=20768
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8303
AFFECTED FILES
anthonyfieroni added a comment.
Baloo doesn't have active developers so you can add Aacid to accept it.
INLINE COMMENTS
> metadatafilter.cpp:44
> {
> const int currentVersion = 6; // increase version, if the blacklist of
> disabled
> // properties should be updated
Increase it li
ngraham edited the test plan for this revision.
ngraham added reviewers: Dolphin, KDE Applications, Frameworks.
ngraham added a project: Dolphin.
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D8303
To: ngraham, #dolphin, #kde_applications, #frameworks
Cc: spoorun,
12 matches
Mail list logo
