mlaurent added inline comments.
INLINE COMMENTS
> kfileplacesmodel.cpp:77
> +if (day > 0) {
> +date += QString("-%1").arg(day, 2, 10, QChar('0'));
> +}
QStringLiteral("-%1").arg(...)
> kfileplacesmodel.cpp:96
> +timelineUrl = QUrl(timelinePrefix + timelin
mlaurent added a comment.
oh it was abandoned ! ok :)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8862
To: renatoo, dfaure, mwolff
Cc: mlaurent, mwolff, dfaure, ngraham, #frameworks
renatoo abandoned this revision.
renatoo added a comment.
This review was spited in small ones:
https://phabricator.kde.org/D8943
https://phabricator.kde.org/D8944
https://phabricator.kde.org/D8945
https://phabricator.kde.org/D8946
https://phabricator.kde.org/D8947
https://phabri
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kfileplacesmodel.cpp:913
>
> +bool KFilePlacesModel::movePlace(int row, int before)
> +{
This should get its own unittest, especially since there are lots o
dfaure added a comment.
This seems to be bundling several unrelated additions into the same commit?
Please have one commit per feature / change / addition.
I know that phabricator makes it difficult to have one review per commit, but
at least the commits should be separate.
INLINE COMM
renatoo updated this revision to Diff 22703.
renatoo added a comment.
Created a public function 'moveItem' to be used by external apps
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8862?vs=22673&id=22703
REVISION DETAIL
https://phabricator.kde.org/D8862
AF
renatoo updated this revision to Diff 22673.
renatoo added a comment.
Added a new role to access icon name property
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8862?vs=22666&id=22673
REVISION DETAIL
https://phabricator.kde.org/D8862
AFFECTED FILES
auto
renatoo updated this revision to Diff 22666.
renatoo marked 4 inline comments as done.
renatoo added a comment.
Fixed code style
Added more unit test
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8862?vs=22652&id=22666
REVISION DETAIL
https://phabricator.
renatoo updated this revision to Diff 22652.
renatoo added a comment.
Renamed function from convertUrl to convertedUrl
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8862?vs=22651&id=22652
REVISION DETAIL
https://phabricator.kde.org/D8862
AFFECTED FILES
s
renatoo updated this revision to Diff 22651.
renatoo added a comment.
Created new function convertUrl
Added @since tag to new functions
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8862?vs=22510&id=22651
REVISION DETAIL
https://phabricator.kde.org/D8862
mwolff added a comment.
the new API and functionality should be covered by tests, it isn't so far as
far as I can see.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8862
To: renatoo, dfaure
Cc: mwolff, dfaure, ngraham, #frameworks
mwolff requested changes to this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8862
To: renatoo, dfaure, mwolff
Cc: mwolff, dfaure, ngraham, #frameworks
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kfileplacesmodel.cpp:281
> KFilePlacesItem *item = static_cast *>(index.internalPointer());
> -
> -if (!item->isDevice()) {
> -return item->bo
renatoo retitled this revision from "Extend API" to "Extend KFilePlacesModel
API".
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8862
To: renatoo
Cc: #frameworks
14 matches
Mail list logo
