dhaumann added a comment.
Herald edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed:
Frameworks.
Curent state: This patch is only almost good to go in... :-P
INLINE COMMENTS
> cullmann wrote in kateview.cpp:3595
> I think the old code tried to ensure we only add word-boun
cullmann added a comment.
For the QLatin1String on the right side in some contructors: should it not be
always QStringLiteral? Not that it will matter a lot.
INLINE COMMENTS
> dhaumann wrote in kateview.cpp:3595
> Now that's a good point: I don't completely.
> It appends a leading and traili
cullmann added a comment.
I think beside the
> I think the old code tried to ensure we only add word-boundary if we still
can find the string then. e.g. if the string that you highlight contains spaces
or stuff like that at the borders, you don't add \b.
all other comments are just
dhaumann created this revision.
dhaumann added reviewers: cullmann, kfunk, mwolff.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Please make a careful review. Many of these code
changes are most likely not touch
mwolff added inline comments.
INLINE COMMENTS
> codecompletionmodelcontrollerinterface.cpp:61
>
> -static QRegExp findWordStart(QLatin1String("\\b([_\\w]+)$"));
> -static QRegExp findWordEnd(QLatin1String("^([_\\w]*)\\b"));
> +static QRegularExpression findWordStart(QStringLiteral("
dhaumann marked 5 inline comments as done.
dhaumann added a comment.
Update patch comes in a second.
INLINE COMMENTS
> mwolff wrote in katebookmarks.cpp:129
> static?
I don't think this is critical. Maybe it's even better to not have it static,
since otherwise it'll lurk around until applic
dhaumann updated this revision to Diff 23538.
dhaumann marked 3 inline comments as done.
dhaumann added a comment.
- Minor updates to the patch.
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9175?vs=23437&id=23538
BRANCH
QRegExpCleanup2 (branched fro
dhaumann marked 4 inline comments as done.
dhaumann added a comment.
Mark some comments as done.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D9175
To: dhaumann, cullmann, kfunk, mwolff
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
dhaumann updated this revision to Diff 64248.
dhaumann added a comment.
- Rebase from 2016 to year 2019.
I don't even know whether it still compiles...
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9175?vs=23538&id=64248
BRANCH
QRegExpCleanup2 (
dhaumann updated this revision to Diff 64327.
dhaumann edited the test plan for this revision.
dhaumann removed reviewers: kfunk, mwolff.
dhaumann added a comment.
Patch should be OK now, please review + approve.
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde
dhaumann marked 4 inline comments as done.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D9175
To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh,
ngraham, bruns, demsking, cullmann, sars, dhaumann
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
Ok ;=)
REPOSITORY
R39 KTextEditor
BRANCH
arcpatch-D9175
REVISION DETAIL
https://phabricator.kde.org/D9175
To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:74a77b06db27: Migrate some more QRegExps to
QRegularExpression (authored by dhaumann, committed by cullmann).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9175?
13 matches
Mail list logo
