D9241: Emit 'groupHiddenChanged' signal.

2017-12-08 Thread Phabricator
This revision was automatically updated to reflect the committed changes. Closed by commit R241:f1185dc10acf: Emit groupHiddenChanged signal. (authored by Renato Araujo Oliveira Filho renato.ara...@kdab.com). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D9241: Emit 'groupHiddenChanged' signal.

2017-12-08 Thread Milian Wolff
mwolff accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9241 To: renatoo, franckarrecot, mwolff, mlaurent Cc: mwolff, #frameworks

D9241: Emit 'groupHiddenChanged' signal.

2017-12-08 Thread Laurent Montel
mlaurent accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9241 To: renatoo, franckarrecot, mwolff, mlaurent Cc: mwolff, #frameworks

D9241: Emit 'groupHiddenChanged' signal.

2017-12-07 Thread Renato Oliveira Filho
renatoo marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9241 To: renatoo, franckarrecot, mwolff Cc: mwolff, #frameworks

D9241: Emit 'groupHiddenChanged' signal.

2017-12-07 Thread Renato Oliveira Filho
renatoo updated this revision to Diff 23617. renatoo added a comment. used static_cast() for cast enums REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9241?vs=23614=23617 REVISION DETAIL https://phabricator.kde.org/D9241 AFFECTED FILES

D9241: Emit 'groupHiddenChanged' signal.

2017-12-07 Thread Milian Wolff
mwolff accepted this revision. mwolff added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kfileplacesmodeltest.cpp:1215 > +QList args = groupHiddenSignal.takeFirst(); > +QCOMPARE(args.at(0).toInt(), (int) KFilePlacesModel::SearchForType); > +

D9241: Emit 'groupHiddenChanged' signal.

2017-12-07 Thread Renato Oliveira Filho
renatoo added a reviewer: franckarrecot. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9241 To: renatoo, franckarrecot Cc: #frameworks

D9241: Emit 'groupHiddenChanged' signal.

2017-12-07 Thread Renato Oliveira Filho
renatoo edited the summary of this revision. renatoo added a dependency: D8450: User can now hide an entire places group from KFilePlacesView. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9241 To: renatoo Cc: #frameworks

D9241: Emit 'groupHiddenChanged' signal.

2017-12-07 Thread Renato Oliveira Filho
renatoo created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Emit 'groupHiddenChanged' when group hidden value change TEST PLAN Unit test created REPOSITORY R241 KIO REVISION DETAIL