D9446: WIP: Allow to autogenerate and install categories file

dfaure added a comment. I don't understand what difference that would make. Any user of project_debug.h would get recompiled every time that file (or one of the files it includes) is modified (i.e. every time a category is added, modified or removed). So if every piece of code should

D9446: WIP: Allow to autogenerate and install categories file

habacker added a comment. In D9446#284822 , @dfaure wrote: > On the other hand it means that when you add a new category, you get to recompile *everything* :-) I understand what you mean, what can be solved by an additional include file

D9446: WIP: Allow to autogenerate and install categories file

dfaure added a comment. On the other hand it means that when you add a new category, you get to recompile *everything* :-) REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D9446 To: mlaurent, kfunk, lbeltrame, cgiboudeaux, dfaure, fvogt Cc: ltoscano,

D9446: WIP: Allow to autogenerate and install categories file

habacker added a comment. In D9446#284185 , @ltoscano wrote: > There can be more headers file for the same repository, and it has not been a problem in practice because the categories usually maps to different groups of files in different

D9446: WIP: Allow to autogenerate and install categories file

habacker added a comment. - doc in file header is missing - test case is missing INLINE COMMENTS > ECMQtDeclareLoggingCategory.cmake:68 > set(options) > -set(oneValueArgs HEADER IDENTIFIER CATEGORY_NAME DEFAULT_SEVERITY) > +set(oneValueArgs HEADER IDENTIFIER CATEGORY_NAME

D9446: WIP: Allow to autogenerate and install categories file

habacker added a comment. In D9446#284272 , @habacker wrote: > In D9446#181785 , @mlaurent wrote: > > > IT's a WIP as I use file(APPEND...) because I want to generate several categories in one file.

D9446: WIP: Allow to autogenerate and install categories file

ltoscano added a comment. In D9446#284288 , @cgiboudeaux wrote: > > There are several issues that need fixes: > > - Installation dir for categories, /etc/xdg on linux has always been wrong. categories are not config files

D9446: WIP: Allow to autogenerate and install categories file

cgiboudeaux added a comment. In D9446#284272 , @habacker wrote: > In D9446#181785 , @mlaurent wrote: > > > IT's a WIP as I use file(APPEND...) because I want to generate several categories in one

D9446: WIP: Allow to autogenerate and install categories file

habacker added a comment. In D9446#181785 , @mlaurent wrote: > IT's a WIP as I use file(APPEND...) because I want to generate several categories in one file. > But it doesn't work as I don't have idea how to reset file when cmake is

D9446: WIP: Allow to autogenerate and install categories file

ltoscano added a comment. There can be more headers file for the same repository, and it has not been a problem in practice because the categories usually maps to different groups of files in different directories. See for example kopete, wacomtablet o kgraphviewer. REPOSITORY R240

D9446: WIP: Allow to autogenerate and install categories file

habacker added a comment. Restricted Application edited subscribers, added: kde-buildsystem, kde-frameworks-devel; removed: Frameworks, Build System. Having support for defining multiple debug categories has an additional issue as shown with the following example. As far as I can see there

D9446: WIP: Allow to autogenerate and install categories file

mlaurent abandoned this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D9446 To: mlaurent, kfunk, lbeltrame, cgiboudeaux, dfaure, fvogt Cc: #frameworks, #build_system, michaelh, ngraham

D9446: WIP: Allow to autogenerate and install categories file

fvogt added a comment. `${KDE_INSTALL_CONFDIR}` should be changed to somewhere else (but maybe in a different patch) IMO `file(APPEND ...)` is the wrong approach, it should collect all categories in a variable and only write it out once at the end (with configure_file). I'm not fluent

D9446: WIP: Allow to autogenerate and install categories file

lbeltrame added a comment. For those who wonder why this would be necessary, see https://mail.kde.org/pipermail/kde-frameworks-devel/2017-December/054139.html. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D9446 To: mlaurent, kfunk, lbeltrame,

D9446: WIP: Allow to autogenerate and install categories file

lbeltrame added a reviewer: fvogt. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D9446 To: mlaurent, kfunk, lbeltrame, cgiboudeaux, dfaure, fvogt Cc: #frameworks, #build_system

D9446: WIP: Allow to autogenerate and install categories file

mlaurent added reviewers: kfunk, lbeltrame, cgiboudeaux, dfaure. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D9446 To: mlaurent, kfunk, lbeltrame, cgiboudeaux, dfaure Cc: #frameworks, #build_system

D9446: WIP: Allow to autogenerate and install categories file

mlaurent added a comment. IT's a WIP as I use file(APPEND...) because I want to generate several categories in one file. But it doesn't work as I don't have idea how to reset file when cmake is started... Do you have an idea ? I will implement autotest and co if we have a

D9446: WIP: Allow to autogenerate and install categories file

mlaurent created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. TEST PLAN Generate kmail categories file REPOSITORY R240 Extra CMake Modules BRANCH autogenerate_categories_file REVISION