D27263: RFC: Accent colour for KColorScheme

cblack abandoned this revision. cblack added a comment. https://invent.kde.org/frameworks/kconfigwidgets/-/merge_requests/24 REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27263 To: cblack, #plasma Cc: The-Feren-OS-Dev, ngraham, kde-frameworks-devel, ndavis,

D25814: [KColorScheme] Add SeparatorColor

ndavis added a comment. How would we add the separator role to color scheme files if separator color was added to upstream Qt? Wouldn't we still need to add a separator role to KColorScheme so that we could map the color in the color scheme file to the equivalent QPalette Colo

D25814: [KColorScheme] Add SeparatorColor

ndavis abandoned this revision. ndavis added a comment. Abandoning this since others would rather have this in QPalette REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25814 To: ndavis, #frameworks, #vdg Cc: ahiemstra, broulik, manueljlin, alexde, ngraham, dav

D25814: [KColorScheme] Add SeparatorColor

ndavis added a comment. OK, I can agree with contributing upstream. I'll try talking on that bug report. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25814 To: ndavis, #frameworks, #vdg Cc: ahiemstra, broulik, manueljlin, alexde, ngraham, davidedmundson, f

D25814: [KColorScheme] Add SeparatorColor

davidedmundson added a comment. Relevant link on that last comment: https://bugreports.qt.io/browse/QTBUG-63331 They actively seeked our opinion on colour roles REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25814 To: ndavis, #frameworks, #vdg Cc: ahiem

D25814: [KColorScheme] Add SeparatorColor

cfeck added a comment. There is QPalette::Button, but I don't see any hover/focus colors in QPalette. If we want more roles, we seriously need to contribute them upstream. Qt 6 is a chance to avoid diverging more. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kd

D25814: [KColorScheme] Add SeparatorColor

ahiemstra added a comment. I actually ran into this with the new Card designs I implemented in Kirigami. Kirigami right now does a lot of `tint(backgroundColor, textColor)` to generate separator colours. However, this leads to potential differences when the color set is View vs. Window or ot

D25814: [KColorScheme] Add SeparatorColor

ngraham added a comment. I have to agree with @ndavis here. Adding a separator color to the color scheme seems sensible enough to me, for the reasons previously provided. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25814 To: ndavis, #frameworks, #vdg Cc:

D25814: [KColorScheme] Add SeparatorColor

ndavis added a comment. In D25814#598380 , @cfeck wrote: > > Why don't focus and hover colors belong? > > Because an application cannot know if and how a style does indicate focus or hovering. I don't understand this objection. What w

D27263: RFC: Accent colour for KColorScheme

ngraham added a comment. Whoops, my bad. Tested this and found that setting an accept color seems to work for apps, but unsetting it doesn't go back to the color-scheme-provided one. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27263 To: cblack, #plas

D27263: RFC: Accent colour for KColorScheme

cblack updated this revision to Diff 79517. cblack added a comment. Fix typo REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27263?vs=75311&id=79517 BRANCH kcolorscheme-accent (branched from master) REVISION DETAIL https://phabricator.kde

D27263: RFC: Accent colour for KColorScheme

ngraham added a comment. Looks like plasma doesn't respect the accent color. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27263 To: cblack, #plasma Cc: The-Feren-OS-Dev, ngraham, kde-frameworks-devel, ndavis, LeGast00n, cblack, GB_2, michaelh, bruns

D27263: RFC: Accent colour for KColorScheme

cblack added a dependent revision: D27271: [kcms/colors] RFC: Accent Colours. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27263 To: cblack, #plasma Cc: The-Feren-OS-Dev, ngraham, kde-frameworks-devel, ndavis, LeGast00n, cblack, GB_2, michaelh, bruns

D27263: RFC: Accent colour for KColorScheme

cblack edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27263 To: cblack, #plasma Cc: The-Feren-OS-Dev, ngraham, kde-frameworks-devel, ndavis, LeGast00n, cblack, GB_2, michaelh, bruns

D27263: RFC: Accent colour for KColorScheme

cblack updated this revision to Diff 75311. cblack added a comment. Expose method to drop accent colours from a KColorScheme object REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27263?vs=75310&id=75311 BRANCH kcolorscheme-accent (branched

D27263: RFC: Accent colour for KColorScheme

cblack edited the summary of this revision. cblack edited the test plan for this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27263 To: cblack, #plasma Cc: The-Feren-OS-Dev, ngraham, kde-frameworks-devel, ndavis, LeGast00n, cblack, GB_2, michaelh, br

D27263: RFC: Accent colour for KColorScheme

cblack updated this revision to Diff 75310. cblack added a comment. Load accent colour from kdeglobals instead of colourscheme REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27263?vs=75289&id=75310 BRANCH kcolorscheme-accent (branched from ma

D27263: RFC: Accent colour for KColorScheme

ndavis added a comment. I know this isn't the final version, but I'm not a fan of this idea. It feels like we'd just piling new stuff on top without properly using the old stuff that is already usable. I think if we're not careful, it'll just make color customization more confusing and diffi

D27263: RFC: Accent colour for KColorScheme

cblack edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27263 To: cblack, #plasma Cc: The-Feren-OS-Dev, ngraham, kde-frameworks-devel, ndavis, LeGast00n, cblack, GB_2, michaelh, bruns

D27263: RFC: Accent colour for KColorScheme

cblack added a task: T11052: Accent Colors, Color Ramps and other improvements to theming.. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27263 To: cblack, #plasma Cc: The-Feren-OS-Dev, ngraham, kde-frameworks-devel, ndavis, LeGast00n, cblack, GB_2, michaelh,

D27263: RFC: Accent colour for KColorScheme

cblack planned changes to this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27263 To: cblack, #plasma Cc: The-Feren-OS-Dev, ngraham, kde-frameworks-devel, ndavis, LeGast00n, cblack, GB_2, michaelh, bruns

D27263: RFC: Accent colour for KColorScheme

implemented via modifiying KColorScheme. Notes about what sucks currently: - No way to query the true colour of an item getting overidden by an accent colour (bad for stuff like KColorSchemeEditor) - Accent color text on accent colour background is 100% unreadable Stuff I plan to do

D25814: [KColorScheme] Add SeparatorColor

cfeck added a comment. > Why don't focus and hover colors belong? Because an application cannot know if and how a style does indicate focus or hovering. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25814 To: ndavis, #frameworks, #vdg Cc: broulik, manu

D25814: [KColorScheme] Add SeparatorColor

ndavis added a comment. I think this is still ultimately the right thing to do. Making the frame/separator color a mix of 2 other colors makes it harder to get just the right color for both the light and dark variations of a theme unless you design the color palettes to solve problems in the

D25814: [KColorScheme] Add SeparatorColor

ndavis added a subscriber: broulik. ndavis added a comment. In D25814#591053 , @ngraham wrote: > I wonder if a path forward is to move this option into Breeze itself and keep it out of the color scheme. We would add an option for "dark separators

D25814: [KColorScheme] Add SeparatorColor

ngraham added a comment. I wonder if a path forward is to move this option into Breeze itself and keep it out of the color scheme. We would add an option for "dark separators when using a dark color scheme" in the super hidden Breeze settings window. REPOSITORY R265 KConfigWidgets REVISIO

D25814: [KColorScheme] Add SeparatorColor

ndavis added a comment. In D25814#574395 , @filipf wrote: > Already asked in VDG, but repeating here: how would we handle dark separators on really dark color schemes? > > This is the most downloaded color scheme and it won't work well with d

D25814: [KColorScheme] Add SeparatorColor

filipf added a comment. In D25814#574389 , @ngraham wrote: > In D25814#574380 , @ndavis wrote: > > > FWIW, Adwaita Dark uses dark separators, but GNOME doesn't use nearly as many icons as we do. F780

D25814: [KColorScheme] Add SeparatorColor

ngraham added a comment. In D25814#574380 , @ndavis wrote: > FWIW, Adwaita Dark uses dark separators, but GNOME doesn't use nearly as many icons as we do. F7806761: Screenshot_20191209_155912.png To

D25814: [KColorScheme] Add SeparatorColor

ndavis added a comment. In D25814#574356 , @hpereiradacosta wrote: > I meant: do the "light" (with window text color) toolbar icons play well with dark toolbar separators as opposed to current semi-light toolbar separators I assume you m

D25814: [KColorScheme] Add SeparatorColor

hpereiradacosta added a comment. > I'm not sure what you mean when you wonder how it would play with monochrome icons. It should have nothing to do with them unless you embed stylesheets in the SVGs to use the separator color in breeze icons. I meant: do the "light" (with window te

D25814: [KColorScheme] Add SeparatorColor

ndavis added a comment. In D25814#574250 , @hpereiradacosta wrote: > - You should add toolbar separators, tabboxes and group boxes to that. For toolbar separators, I wonder how this would play with monochrome (color-themed) icons. I'm n

D25814: [KColorScheme] Add SeparatorColor

hpereiradacosta added a comment. In D25814#574197 , @ndavis wrote: > In D25814#574160 , @davidedmundson wrote: > > > Can we clarify what separators we're referring to. > > > Frames around UI el

D25814: [KColorScheme] Add SeparatorColor

hpereiradacosta added a comment. > So the background here is that we've gotten a new VDG designer who produced mockups of Breeze dark with dark separators, and some people absolutely fell in love with them, while other people hated them. We could not achieve consensus on moving to use

D25814: [KColorScheme] Add SeparatorColor

ngraham added a comment. In D25814#574197 , @ndavis wrote: > In D25814#574160 , @davidedmundson wrote: > > > Can we clarify what separators we're referring to. > > > Frames around UI elements a

D25814: [KColorScheme] Add SeparatorColor

tra option for this specific theme, rather than forcing it to kcolorscheme and imposing it to all styles (or making kcolorscheme broken for all the styles that wont use it). This is how window decoration shadows and glow were handled to oxygen. I think this change will break more things than it wil

D25814: [KColorScheme] Add SeparatorColor

ndavis added a comment. In D25814#574160 , @davidedmundson wrote: > Can we clarify what separators we're referring to. Frames around UI elements and horizontal/vertical lines that separate UI elements. These are the most common example

D25814: [KColorScheme] Add SeparatorColor

davidedmundson added a comment. Can we clarify what separators we're referring to. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25814 To: ndavis, #frameworks, #vdg Cc: davidedmundson, filipf, cfeck, hpereiradacosta, kde-frameworks-devel, LeGast00n, GB_2, m

D25814: [KColorScheme] Add SeparatorColor

cfeck added a comment. I also agree with the concerns rised by Hugo. An application will use various frame primitives, and the style decides how to draw them. It doesn't belong in the API, though (but neither do Focus and Hover colors). REPOSITORY R265 KConfigWidgets REVISION DETAIL htt

D25814: [KColorScheme] Add SeparatorColor

dfaure resigned from this revision. dfaure added a comment. This revision now requires review to proceed. Hugo's arguments make sense, removing my approval. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25814 To: ndavis, #frameworks, #vdg Cc: filipf, cfeck,

D25814: [KColorScheme] Add SeparatorColor

r for this will not fit such schemes. - in the end if you need an extra color for a given theme (be it future-breeze or whatever), there is also the possibility to add it as a extra option for this specific theme, rather than forcing it to kcolorscheme and imposing it to all styles (or m

D25814: [KColorScheme] Add SeparatorColor

filipf added a comment. I think this is useful. Every once in a while we get opinionated people who think light separators are awful in the Breeze Dark scheme (I would hate dark ones on the other hand) or even some ricer people who want to turn off separators (which they could do now by matc

D25814: [KColorScheme] Add SeparatorColor

D25814#574105>, @hpereiradacosta wrote: > Adding new entries to the kcolorscheme should be done with a lot of care, because it could be seen as some sort of API break for existing colorscheme, as soon as you start using this color in the widget style: you would need a fallback implementation, for all

D25814: [KColorScheme] Add SeparatorColor

hpereiradacosta added a subscriber: cfeck. hpereiradacosta added a comment. Would also be good to have the opinion of @cfeck on this. REPOSITORY R265 KConfigWidgets BRANCH separator-color (branched from master) REVISION DETAIL https://phabricator.kde.org/D25814 To: ndavis, #frameworks

D25814: [KColorScheme] Add SeparatorColor

hpereiradacosta added a comment. Adding new entries to the kcolorscheme should be done with a lot of care, because it could be seen as some sort of API break for existing colorscheme, as soon as you start using this color in the widget style: you would need a fallback implementation, for

D25814: [KColorScheme] Add SeparatorColor

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Code looks OK. No opinion on usefulness though. REPOSITORY R265 KConfigWidgets BRANCH separator-color (branched from master) REVISION DETAIL https://phabricator.kde.org/D25814 To: n

D25814: [KColorScheme] Add SeparatorColor

ndavis updated this revision to Diff 71096. ndavis added a comment. - update @since version REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25814?vs=71095&id=71096 BRANCH separator-color (branched from master) REVISION DETAIL https://phabricator

D25814: [KColorScheme] Add SeparatorColor

ndavis edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25814 To: ndavis, #frameworks, #vdg, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25814: [KColorScheme] Add SeparatorColor

ndavis edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25814 To: ndavis, #frameworks, #vdg, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25814: [KColorScheme] Add SeparatorColor

ndavis edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25814 To: ndavis, #frameworks, #vdg, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25814: [KColorScheme] Add SeparatorColor

ndavis edited the summary of this revision. ndavis added reviewers: Frameworks, VDG, dfaure. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25814 To: ndavis, #frameworks, #vdg, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25814: [KColorScheme] Add SeparatorColor

ndavis created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Users sometimes ask for the ability to customize the color of separators. When talking about how the next version of Bre

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

This revision was automatically updated to reflect the committed changes. Closed by commit R265:45b6460b0c09: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items (authored by ndavis). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis marked 2 inline comments as done. REPOSITORY R265 KConfigWidgets BRANCH arcpatch-D25677 (branched from master) REVISION DETAIL https://phabricator.kde.org/D25677 To: ndavis, #frameworks, dfaure Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis updated this revision to Diff 70812. ndavis added a comment. More code formatting REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25677?vs=70802&id=70812 BRANCH arcpatch-D25677 (branched from master) REVISION DETAIL https://phabricator.kd

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kcolorscheme.cpp:289 > struct { > -QBrush fg[8], bg[8], deco[2]; > + QBrush fg[KColorScheme::NForegroundRoles], > bg[KColorScheme::N

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis marked 3 inline comments as done. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25677 To: ndavis, #frameworks, dfaure Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis updated this revision to Diff 70802. ndavis added a comment. - [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items - fix code style REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25677?vs=70720&id=70802 BRANCH arcp

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

This revision was automatically updated to reflect the committed changes. Closed by commit R265:38b02c1baa84: [KColorScheme] Add items to ColorSet and Role enums for the total number of… (authored by ndavis). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets BRANCH enum-item-counts (branched from master) REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks, dfaure, davidedmundson, hpereiradacosta Cc: kde-framewo

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

> +for(auto &effect : _effects) effect = 0; > coding style: space after `for`, and add `{` ... `}` around the body, with newlines. > kcolorscheme.cpp:393 > { > -switch (role) { > -case KColorScheme::AlternateBackground: > - return _brushes.bg[1]; &g

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis added a comment. In D25677#570896 , @ngraham wrote: > > This also replaces some for-loops with C++11 range based for-loops and switches for simpler if/else control blocks. > > Seems like these changes are unrelated and should maybe be

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ngraham added a comment. All right. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25677 To: ndavis, #frameworks, dfaure Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ngraham added a comment. > This also replaces some for-loops with C++11 range based for-loops and switches for simpler if/else control blocks. Seems like these changes are unrelated and should maybe be in a separate commit? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://pha

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

ngraham added reviewers: davidedmundson, hpereiradacosta. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks, dfaure, davidedmundson, hpereiradacosta Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

ndavis added a reviewer: dfaure. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis added a reviewer: dfaure. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25677 To: ndavis, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

ndavis edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis added a reviewer: Frameworks. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25677 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

ndavis added a dependent revision: D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis added a dependency: D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25677 To: ndavis Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

ndavis created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY This also replaces some for-loops with C++11 range based for-loops and switches for simpler if/else control blocks. TEST

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

ndavis edited the test plan for this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25676 To: ndavis, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

ndavis updated this revision to Diff 70718. ndavis added a comment. - Split up Effects enum REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25676?vs=70717&id=70718 BRANCH enum-item-counts (branched from master) REVISION DETAIL https://phabricato

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

ndavis retitled this revision from "Add items to ColorSet and Role enums for the total number of items" to "[KColorScheme] Add items to ColorSet and Role enums for the total number of items". REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.or

D24060: Make KColorScheme compatible with QVariant

vkrause added a task: T8837: QColor support for Grantlee. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D24060 To: vkrause, dfaure Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24060: Make KColorScheme compatible with QVariant

vkrause added a dependent revision: D24094: Add support for KColorScheme. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D24060 To: vkrause, dfaure Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24060: Make KColorScheme compatible with QVariant

This revision was automatically updated to reflect the committed changes. Closed by commit R265:d65940d8e882: Make KColorScheme compatible with QVariant (authored by vkrause). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24060?vs=66401&id=6

D24060: Make KColorScheme compatible with QVariant

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Haha that's lucky! REPOSITORY R265 KConfigWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D24060 To: vkrause, dfaure Cc: dfaure, kde-frameworks-devel, LeGast00n, G

D24060: Make KColorScheme compatible with QVariant

vkrause added a comment. In D24060#534122 <https://phabricator.kde.org/D24060#534122>, @dfaure wrote: > Does this break source compatibility with code currently doing Q_DECLARE_METATYPE(KColorScheme) already? No, as Q_DECLARE_METATYPE requires the type to have a def

D24060: Make KColorScheme compatible with QVariant

dfaure added a comment. Does this break source compatibility with code currently doing Q_DECLARE_METATYPE(KColorScheme) already? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D24060 To: vkrause Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh

D24060: Make KColorScheme compatible with QVariant

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This requires default constructability and a meta type declaration. The use-case for this is to expose a KColorScheme

D18612: Cache the default KColorScheme configuration

This revision was automatically updated to reflect the committed changes. Closed by commit R265:c0cc6b8a200a: Cache the default KColorScheme configuration (authored by mwolff). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18612?vs=50541&id=51212#toc REPOSITORY R265 KConfigWid

D18612: Cache the default KColorScheme configuration

mwolff added a comment. pushed this now with a proper benchmark too, shows a ~10x performance win when a non-empty PATH is set REPOSITORY R265 KConfigWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D18612 To: mwolff, #kate, #kdevelop, dfaure, broulik Cc: broulik, kd

D18612: Cache the default KColorScheme configuration

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D18612 To: mwolff, #kate, #kdevelop, dfaure, broulik Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D18612: Cache the default KColorScheme configuration

mwolff added a comment. sure, but first let's get this in. @broulik or @dfaure care to give your +1? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D18612 To: mwolff, #kate, #kdevelop, dfaure Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D18612: Cache the default KColorScheme configuration

broulik added a comment. I also noticed that on application startup two default color schemes are created: One by plasma-integration set on `QApplication` and the other by `QStyle::standardPalette()` in the widget style. I couldn't figure out a way to avoid this (have QStyle use the default

D18612: Cache the default KColorScheme configuration

mwolff added a comment. I see that it's faster when I profile kate/kdev, but I cannot easily write a benchmark for this. It's only noticeable when the KDE_COLOR_SCHEME_PATH variable is set, otherwise the global application config will be used afte rall, which is going to be shared most proba

D18612: Cache the default KColorScheme configuration

KColorScheme instances repeatedly. This was very costly since we ended up reparsing the internal color scheme configuration file every time - the shared configuration wasn't stored anywhere thus it's refcount dropped to zero after once the KColorScheme was fully constructed. Opt

KColorScheme::BackgroundRole and theming

Hi, FYI, I just launched an idea in Visual Design Group forum (https:// forum.kde.org/viewtopic.php?f=285&t=153023) with an implicit question: is there a reason KColorScheme::BackgroundRole was never exposed completely to theming? R.

D9768: Cache KColorScheme instances

This revision was automatically updated to reflect the committed changes. Closed by commit R858:89760fddd4cb: Cache KColorScheme instances (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9768?vs=25031&id=25032#toc REPOSITORY R858 Qt Quick Controls 2: Desktop S

D9768: Cache KColorScheme instances

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH master REVISION DETAIL https://phabricator.kde.org/D9768 To: apol, #frameworks, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensr

D9768: Cache KColorScheme instances

apol created this revision. apol added reviewers: Frameworks, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY This patch catches the few different KColorScheme we use so that

[Differential] [Commented On] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

kfunk added a comment. Thanks for the investigation, Francis! \o/ REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D4637 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: flherne, #frameworks, graesslin Cc: kfunk, graesslin

[Differential] [Closed] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

This revision was automatically updated to reflect the committed changes. Closed by commit R265:a3355b22954b: KColorScheme: default to application scheme if set by KColorSchemeManager (authored by flherne). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org

[Differential] [Accepted] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D4637 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: flherne, #frameworks, graesslin Cc: graess

[Differential] [Updated] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

flherne marked an inline comment as done. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D4637 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: flherne, #frameworks Cc: graesslin

[Differential] [Updated, 43 lines] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

flherne updated the test plan for this revision. flherne updated this revision to Diff 11471. flherne added a comment. Update the commits / docstrings REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4637?vs=11439&id=11471 REVISION DETAIL https://ph

[Differential] [Commented On] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

graesslin added inline comments. INLINE COMMENTS > kcolorscheme.h:316-318 > + * from the given KConfig. If null, the application's > KDE_COLOR_SCHEME_PATH > + * property will be used to load a KConfig. If this is also unset, the > + * system colors will be used. I wouldn't mention t

[Differential] [Commented On] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

graesslin added a comment. > That's not new, the property's been set here since at least the kdelibs split. I know, I was the one adding it :-) That's also why I think we could do that better than a property: it was intended as a way to communicate with the QStyle - the aim of the prope

  1   2   >