Re: Review Request 122576: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated March 11, 2015, 11:08 p.m.) Status -- This change has been

Re: Review Request 122576: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/#review77316 --- Moved to knewstuff: https://git.reviewboard.kde.org/r/122910/

Re: Review Request 122576: Introduce KMoreTools

> On March 7, 2015, 9:04 a.m., David Faure wrote: > > KService is basically ksycoca. One day I hope we can move away from that, > > which means all of kservice could then be deprecated. > > So it still makes sense to *use* kservice where looking up desktop files is > > needed (it's our current

Re: Review Request 122576: Introduce KMoreTools

> On March 7, 2015, 9:04 a.m., David Faure wrote: > > KService is basically ksycoca. One day I hope we can move away from that, > > which means all of kservice could then be deprecated. > > So it still makes sense to *use* kservice where looking up desktop files is > > needed (it's our current

Re: Review Request 122576: Introduce KMoreTools

> On March 7, 2015, 9:04 a.m., David Faure wrote: > > KService is basically ksycoca. One day I hope we can move away from that, > > which means all of kservice could then be deprecated. > > So it still makes sense to *use* kservice where looking up desktop files is > > needed (it's our current

Re: Review Request 122576: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/#review77147 --- KService is basically ksycoca. One day I hope we can move away

Re: Review Request 122576: Introduce KMoreTools

> On Feb. 16, 2015, 11:12 a.m., Aleix Pol Gonzalez wrote: > > src/CMakeLists.txt, line 81 > > > > > > I don't think this class is enough reason to make KService depend on > > QtWidgets. I think so, too. Any othe

Re: Review Request 122576: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated March 1, 2015, 2:28 p.m.) Review request for KDE Frameworks, Dom

Re: Review Request 122576: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated March 1, 2015, 10:59 a.m.) Review request for KDE Frameworks, Do

Re: Review Request 122576: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated Feb. 22, 2015, 11:24 p.m.) Review request for KDE Frameworks, Do

Re: Review Request 122576: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated Feb. 22, 2015, 8:34 p.m.) Review request for KDE Frameworks, Dom

Re: Review Request 122576: Introduce KMoreTools

> On feb. 22, 2015, 1:52 p.m., Albert Astals Cid wrote: > > src/kmoretools/kmoretoolsconfigdialog.h, line 27 > > > > > > Why is a non private header including a private header? > > Gregor Mi wrote: > kmoretoo

Re: Review Request 122576: Introduce KMoreTools

> On Feb. 22, 2015, 1:52 p.m., Albert Astals Cid wrote: > > src/kmoretools/kmoretoolsconfigdialog.h, line 27 > > > > > > Why is a non private header including a private header? kmoretoolsconfigdialog.h should be

Re: Review Request 122576: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/#review76422 --- src/kmoretools/kmoretoolsconfigdialog.h

Re: Review Request 122576: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated Feb. 16, 2015, 11:05 p.m.) Review request for KDE Frameworks, Do

Re: Review Request 122576: Introduce KMoreTools

> On feb. 16, 2015, 10:28 p.m., Albert Astals Cid wrote: > > You're missing lots of const in your getters and const & in your params > > Gregor Mi wrote: > Thx for the hint, I added now lots of const in the getters. > With "const & in params" are referring to QString parameters? I though

Re: Review Request 122576: Introduce KMoreTools

> On Feb. 16, 2015, 10:28 p.m., Albert Astals Cid wrote: > > You're missing lots of const in your getters and const & in your params Thx for the hint, I added now lots of const in the getters. With "const & in params" are referring to QString parameters? I thought they were reference counted.

Re: Review Request 122576: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated Feb. 16, 2015, 10:36 p.m.) Review request for KDE Frameworks, Do

Re: Review Request 122576: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated Feb. 16, 2015, 10:30 p.m.) Review request for KDE Frameworks, Do

Re: Review Request 122576: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/#review76158 --- You're missing lots of const in your getters and const & in yo

Re: Review Request 122576: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/#review76114 --- src/CMakeLists.txt