Re: Review Request 124213: Add standard shortcut for new tab action

2015-07-03 Thread Simon Persson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124213/ --- (Updated July 4, 2015, 1:04 a.m.) Review request for KDE Frameworks.

Re: Review Request 124213: Add standard shortcut for new tab action

2015-07-01 Thread Simon Persson
On June 30, 2015, 12:07 p.m., Kai Uwe Broulik wrote: +1 for Ctrl+T but not sure about Ctrl+Shift+N, never seen that used for that purpose, just incognito mode, or new window in applications like Konsole. You can see that ctrl+. (period) is the current default in kstandardshortcut.cpp.

Re: Review Request 124213: Add standard shortcut for new tab action

2015-06-30 Thread David Faure
On June 30, 2015, 12:07 p.m., Kai Uwe Broulik wrote: src/gui/kstandardshortcut.h, line 372 https://git.reviewboard.kde.org/r/124213/diff/1/?file=381769#file381769line372 Isn't Ctrl+Tab usually next tab? Aleix Pol Gonzalez wrote: Here, Konsole uses shift+arrow to change tab.

Re: Review Request 124213: Add standard shortcut for new tab action

2015-06-30 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124213/#review81896 --- +1 for Ctrl+T but not sure about Ctrl+Shift+N, never seen

Re: Review Request 124213: Add standard shortcut for new tab action

2015-06-30 Thread Aleix Pol Gonzalez
On June 30, 2015, 2:07 p.m., Kai Uwe Broulik wrote: src/gui/kstandardshortcut.h, line 372 https://git.reviewboard.kde.org/r/124213/diff/1/?file=381769#file381769line372 Isn't Ctrl+Tab usually next tab? Here, Konsole uses shift+arrow to change tab. Also it doesn't use Ctrl+T. -

Re: Review Request 124213: Add standard shortcut for new tab action

2015-06-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124213/#review81894 --- Makes sense. Maybe it would make sense to reconsider the