Re: Review Request 111688: QVariantList-based ctor for KPluginInfo

2013-08-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111688/ --- (Updated Aug. 5, 2013, 4:25 p.m.) Status -- This change has been

Re: Review Request 111688: QVariantList-based ctor for KPluginInfo

2013-08-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111688/#review37143 --- This review has been submitted with commit

Re: Review Request 111688: QVariantList-based ctor for KPluginInfo

2013-08-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111688/#review37059 --- Ship it! staging/kservice/src/services/kplugininfo.cpp

Re: Review Request 111688: QVariantList-based ctor for KPluginInfo

2013-07-30 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111688/#review36831 --- staging/kservice/src/services/kplugininfo.cpp

Re: Review Request 111688: QVariantList-based ctor for KPluginInfo

2013-07-29 Thread David Faure
On July 25, 2013, 4:32 p.m., David Faure wrote: staging/kservice/src/services/kplugininfo.cpp, line 110 http://git.reviewboard.kde.org/r/111688/diff/1/?file=173292#file173292line110 So args is a list of maps, any of which could contain a MetaData key? This seems strange. What's

Re: Review Request 111688: QVariantList-based ctor for KPluginInfo

2013-07-29 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111688/ --- (Updated July 30, 2013, 2:31 a.m.) Review request for KDE Frameworks and

Re: Review Request 111688: QVariantList-based ctor for KPluginInfo

2013-07-29 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111688/ --- (Updated July 30, 2013, 2:41 a.m.) Review request for KDE Frameworks and

Re: Review Request 111688: QVariantList-based ctor for KPluginInfo

2013-07-28 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111688/ --- (Updated July 29, 2013, 12:25 a.m.) Review request for KDE Frameworks and

Re: Review Request 111688: QVariantList-based ctor for KPluginInfo

2013-07-28 Thread Sebastian Kügler
On July 25, 2013, 4:32 p.m., David Faure wrote: staging/kservice/src/services/kplugininfo.cpp, line 110 http://git.reviewboard.kde.org/r/111688/diff/1/?file=173292#file173292line110 So args is a list of maps, any of which could contain a MetaData key? This seems strange. What's

Re: Review Request 111688: QVariantList-based ctor for KPluginInfo

2013-07-28 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111688/ --- (Updated July 29, 2013, 12:30 a.m.) Review request for KDE Frameworks and

Re: Review Request 111688: QVariantList-based ctor for KPluginInfo

2013-07-25 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111688/ --- (Updated July 25, 2013, 4:10 p.m.) Review request for KDE Frameworks and

Re: Review Request 111688: QVariantList-based ctor for KPluginInfo

2013-07-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111688/#review36498 --- staging/kservice/src/services/kplugininfo.h

Re: Review Request 111688: QVariantList-based ctor for KPluginInfo

2013-07-25 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111688/#review36505 --- staging/kservice/src/services/kplugininfo.cpp