Re: Review Request 112479: Split Bookmarks out of kio folder into own folder in staging

2013-09-08 Thread David Faure
On Sept. 3, 2013, 12:34 p.m., David Faure wrote: staging/kbookmarks/tests/CMakeLists.txt, line 9 http://git.reviewboard.kde.org/r/112479/diff/1/?file=186788#file186788line9 Isn't that only for unittests? David Edmundson wrote: If this is wrong kconfigwidgets and ktextwidgets

Re: Review Request 112479: Split Bookmarks out of kio folder into own folder in staging

2013-09-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112479/ --- (Updated Sept. 4, 2013, 4:59 p.m.) Status -- This change has been

Re: Review Request 112479: Split Bookmarks out of kio folder into own folder in staging

2013-09-04 Thread Wojciech Kapuscinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112479/#review39385 --- kio/bookmarks/kbookmark.h

Review Request 112479: Split Bookmarks out of kio folder into own folder in staging

2013-09-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112479/ --- Review request for KDE Frameworks. Description --- Split Bookmarks

Re: Review Request 112479: Split Bookmarks out of kio folder into own folder in staging

2013-09-03 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112479/#review39255 --- Ship it! Cool. I don't think we want core/gui separation.