Re: Review Request 113248: Cleanup KNotifyConfig

2013-10-18 Thread Aurélien Gâteau
On Oct. 15, 2013, 3:51 p.m., Aurélien Gâteau wrote: Standalone build fails here with this message: -- Found KF5: /home/aurelien/opt/kf5/share/ECM/find-modules/FindKF5.cmake (found suitable version 5.0.0, minimum required is 5.0.0) found components: CMake Compiler InstallDirs

Re: Review Request 113248: Cleanup KNotifyConfig

2013-10-17 Thread Aleix Pol Gonzalez
On Oct. 15, 2013, 1:51 p.m., Aurélien Gâteau wrote: Standalone build fails here with this message: -- Found KF5: /home/aurelien/opt/kf5/share/ECM/find-modules/FindKF5.cmake (found suitable version 5.0.0, minimum required is 5.0.0) found components: CMake Compiler InstallDirs

Re: Review Request 113248: Cleanup KNotifyConfig

2013-10-15 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113248/#review41776 --- staging/knotifyconfig/CMakeLists.txt

Re: Review Request 113248: Cleanup KNotifyConfig

2013-10-15 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113248/#review41778 --- Standalone build fails here with this message: -- Found KF5:

Re: Review Request 113248: Cleanup KNotifyConfig

2013-10-15 Thread Aleix Pol Gonzalez
On Oct. 15, 2013, 1:44 p.m., Kevin Ottens wrote: staging/knotifyconfig/CMakeLists.txt, line 17 http://git.reviewboard.kde.org/r/113248/diff/1/?file=201274#file201274line17 Shouldn't this type of conditional removed now that we use alias targets? Or you plan to change that in

Review Request 113248: Cleanup KNotifyConfig

2013-10-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113248/ --- Review request for KDE Frameworks. Repository: kdelibs Description

Re: Review Request 113248: Cleanup KNotifyConfig

2013-10-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113248/ --- (Updated Oct. 14, 2013, 5:33 p.m.) Review request for KDE Frameworks.