---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113483/#review42587
---
Ship it!
Looks fine to me and is aligned with prior
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113483/#review42589
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113483/
---
(Updated Oct. 29, 2013, 8:28 a.m.)
Status
--
This change has been
On Tuesday 29 October 2013, Stephen Kelly wrote:
Kevin Ottens wrote:
Ship it!
Looks fine to me and is aligned with prior discussions.
Note that it is named ECM_foo, but it contains hardcoded KDE icon theme
names.
Good point.
As it is, IMO for being ECM, it needs way more
On Tuesday 29 October 2013 18:36:03 Alexander Neundorf wrote:
On Tuesday 29 October 2013, Stephen Kelly wrote:
Kevin Ottens wrote:
Ship it!
Looks fine to me and is aligned with prior discussions.
Note that it is named ECM_foo, but it contains hardcoded KDE icon theme
names.
On 2013-10-29, Alexander Neundorf neund...@kde.org wrote:
Good point.
As it is, IMO for being ECM, it needs way more documentation.
It needs to be documented so that it can be used by people who know nothing
about KDE or KDE's icon scheme.
Or should that be in the framework which deals with
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113483/
---
Review request for KDE Frameworks.
Repository: extra-cmake-modules
