Re: Review Request 113657: Fix Standalone Configuration of DNSSD

2013-11-10 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113657/ --- (Updated Nov. 11, 2013, 12:25 a.m.) Status -- This change has been ma

Re: Review Request 113657: Fix Standalone Configuration of DNSSD

2013-11-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113657/#review43396 --- This review has been submitted with commit 39e87ae731a0972f3db

Re: Review Request 113657: Fix Standalone Configuration of DNSSD

2013-11-10 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113657/ --- (Updated Nov. 11, 2013, 12:21 a.m.) Review request for KDE Frameworks, Kev

Re: Review Request 113657: Fix Standalone Configuration of DNSSD

2013-11-10 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113657/#review43351 --- Ship it! I think that's fine to keep the modules private, they

Re: Review Request 113657: Fix Standalone Configuration of DNSSD

2013-11-07 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113657/ --- (Updated Nov. 7, 2013, 1:30 p.m.) Review request for KDE Frameworks, Kevin

Re: Review Request 113657: Fix Standalone Configuration of DNSSD

2013-11-07 Thread David Narváez
> On Nov. 7, 2013, 9:21 a.m., Aurélien Gâteau wrote: > > It's going in the right direction, but I am wondering whether the > > Find*.cmake files should go to extra-cmake-modules instead of being part of > > the framework. You should add Steve (skelly) to the review to get his > > opinion. > >

Re: Review Request 113657: Fix Standalone Configuration of DNSSD

2013-11-07 Thread Aleix Pol Gonzalez
> On Nov. 7, 2013, 9:21 a.m., Aurélien Gâteau wrote: > > It's going in the right direction, but I am wondering whether the > > Find*.cmake files should go to extra-cmake-modules instead of being part of > > the framework. You should add Steve (skelly) to the review to get his > > opinion. Wel

Re: Review Request 113657: Fix Standalone Configuration of DNSSD

2013-11-07 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113657/#review43202 --- It's going in the right direction, but I am wondering whether t

Review Request 113657: Fix Standalone Configuration of DNSSD

2013-11-05 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113657/ --- Review request for KDE Frameworks and Aurélien Gâteau. Repository: kdelibs