Re: Review Request 114701: Print a warning if kimagecache.h is used without KF5::CoreAddons

2013-12-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114701/ --- (Updated Dec. 28, 2013, 1:53 p.m.) Status -- This change has been ma

Re: Review Request 114701: Print a warning if kimagecache.h is used without KF5::CoreAddons

2013-12-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114701/#review46280 --- This review has been submitted with commit 9262517af279df80a0

Re: Review Request 114701: Print a warning if kimagecache.h is used without KF5::CoreAddons

2013-12-28 Thread Alex Merry
> On Dec. 28, 2013, 1:42 p.m., David Faure wrote: > > Ah indeed, well done. Does that mean you're happy for me to ship 114700 as well? - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.or

Re: Review Request 114701: Print a warning if kimagecache.h is used without KF5::CoreAddons

2013-12-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114701/#review46276 --- Ship it! Ah indeed, well done. - David Faure On Dec. 28, 2

Re: Review Request 114701: Print a warning if kimagecache.h is used without KF5::CoreAddons

2013-12-28 Thread Alex Merry
> On Dec. 28, 2013, 1:19 p.m., David Faure wrote: > > See, this will print an unnecessary (i.e. wrong) warning in case we *are* > > linking to KCoreAddons, but not using cmake. > > qmake users will have to add a define just to silence the warning. So this > > create more work, rather than helpi

Re: Review Request 114701: Print a warning if kimagecache.h is used without KF5::CoreAddons

2013-12-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114701/#review46273 --- See, this will print an unnecessary (i.e. wrong) warning in ca

Review Request 114701: Print a warning if kimagecache.h is used without KF5::CoreAddons

2013-12-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114701/ --- Review request for KDE Frameworks. Repository: kguiaddons Description -