Re: Review Request 114990: removing kde4 references from kauth

2014-02-20 Thread Siddharth Sharma
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114990/ --- (Updated Feb. 20, 2014, 12:08 p.m.) Status -- This change has been d

Re: Review Request 114990: removing kde4 references from kauth

2014-01-31 Thread Alex Merry
> On Jan. 13, 2014, 12:09 p.m., Alex Merry wrote: > > src/kauthactionreply.h, line 173 > > > > > > I'm sure no such macro exists. Have a look in > > kauth/cmake/KF5AuthMacros.cmake for what it should become. A

Re: Review Request 114990: removing kde4 references from kauth

2014-01-13 Thread Siddharth Sharma
Thanks looking into porting guide , will do legitimate requests next time. :) ~siddharth On Mon, Jan 13, 2014 at 6:15 PM, Alex Merry wrote: > On 13/01/14 12:41, Siddharth Sharma wrote: > > so basically of all yesterdays review requests, were to know if things > > would change over there or not

Re: Review Request 114990: removing kde4 references from kauth

2014-01-13 Thread Alex Merry
On 13/01/14 12:41, Siddharth Sharma wrote: > so basically of all yesterdays review requests, were to know if things > would change over there or not. did not replaced everything with kde4 -> > kde5 OK, sorry if I came across a bit harsh; I know you're still getting familiar with the frameworks. T

Re: Review Request 114990: removing kde4 references from kauth

2014-01-13 Thread Siddharth Sharma
so basically of all yesterdays review requests, were to know if things would change over there or not. did not replaced everything with kde4 -> kde5 On Mon, Jan 13, 2014 at 5:39 PM, Alex Merry wrote: >This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde

Re: Review Request 114990: removing kde4 references from kauth

2014-01-13 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114990/#review47310 --- src/kauthactionreply.h

Review Request 114990: removing kde4 references from kauth

2014-01-12 Thread Siddharth Sharma
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114990/ --- Review request for KDE Frameworks. Repository: kauth Description --