Re: Review Request 115419: Split KCompletionMatches class into files of its own

2014-02-04 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115419/ --- (Updated Feb. 5, 2014, 12:24 a.m.) Status -- This change has been ma

Re: Review Request 115419: Split KCompletionMatches class into files of its own

2014-02-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115419/#review48994 --- This review has been submitted with commit a9b64341ce5645c348

Re: Review Request 115419: Split KCompletionMatches class into files of its own

2014-02-04 Thread David Gil Oliva
> On Feb. 4, 2014, 11:46 p.m., Alex Merry wrote: > > Hmm... I feel that KCompletionMatchesWrapper is in the wrong place, but I'm > > not entirely sure where it *should* go. Well, it's not in a public header, > > so that's far less urgent (although a potential later task would be to move > > t

Re: Review Request 115419: Split KCompletionMatches class into files of its own

2014-02-04 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115419/#review48988 --- Ship it! Hmm... I feel that KCompletionMatchesWrapper is in t

Re: Review Request 115419: Split KCompletionMatches class into files of its own

2014-02-04 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115419/ --- (Updated Feb. 4, 2014, 11:08 p.m.) Review request for KDE Frameworks. C

Re: Review Request 115419: Split KCompletionMatches class into files of its own

2014-02-04 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115419/#review48900 --- It's getting there :-) src/kcompletion.cpp

Re: Review Request 115419: Split KCompletionMatches class into files of its own

2014-02-03 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115419/ --- (Updated Feb. 4, 2014, 12:36 a.m.) Review request for KDE Frameworks. C