Re: Review Request 116098: Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs

2014-03-04 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116098/ --- (Updated March 4, 2014, 5:13 p.m.) Review request for KDE Frameworks, Dan

Re: Review Request 116098: Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs

2014-03-04 Thread Lamarque Souza
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116098/#review51909 --- Ship it! Ship It! - Lamarque Souza On March 4, 2014, 4:13

Re: Review Request 116098: Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs

2014-03-04 Thread Lamarque Souza
> On March 4, 2014, 4:42 p.m., Lamarque Souza wrote: > > Ship It! This should be ported to branches master and NM/0.9.8 as well. - Lamarque --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/

Re: Review Request 116098: Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs

2014-03-04 Thread Alexander Richardson
> On March 4, 2014, 5:42 p.m., Lamarque Souza wrote: > > Ship It! > > Lamarque Souza wrote: > This should be ported to branches master and NM/0.9.8 as well. How should I commit it? Commit to oldest branch and then merge? Or rather put this into qt5 and then apply patches to the other branc

Re: Review Request 116098: Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs

2014-03-04 Thread Lamarque Souza
> On March 4, 2014, 4:42 p.m., Lamarque Souza wrote: > > Ship It! > > Lamarque Souza wrote: > This should be ported to branches master and NM/0.9.8 as well. > > Alexander Richardson wrote: > How should I commit it? Commit to oldest branch and then merge? Or rather > put this into qt5 a

Re: Review Request 116098: Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs

2014-03-04 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116098/ --- (Updated March 5, 2014, 2:46 a.m.) Status -- This change has been ma

Re: Review Request 116098: Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs

2014-03-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116098/#review52000 --- This review has been submitted with commit fb5d0510dbc136ce9c

Re: Review Request 116098: Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs

2014-03-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116098/#review52076 --- This review has been submitted with commit 9b32aab411fc79d00f

Re: Review Request 116098: Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs

2014-03-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116098/#review52077 --- This review has been submitted with commit 68fa427587a38805f2