Re: Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

2014-03-19 Thread Aaron J. Seigo
On March 17, 2014, 8:33 p.m., Thomas Lübking wrote: src/kwindowsystem_x11.cpp, line 102 https://git.reviewboard.kde.org/r/116787/diff/5/?file=254570#file254570line102 Is this compensated anywhere? Is it actually an issue (since the constructor should operate in the GUI

Re: Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

2014-03-19 Thread Martin Gräßlin
On March 17, 2014, 9:33 p.m., Thomas Lübking wrote: src/kwindowsystem_x11.cpp, line 102 https://git.reviewboard.kde.org/r/116787/diff/5/?file=254570#file254570line102 Is this compensated anywhere? Is it actually an issue (since the constructor should operate in the GUI

Re: Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

2014-03-19 Thread Aaron J. Seigo
On March 17, 2014, 8:33 p.m., Thomas Lübking wrote: src/kwindowsystem_x11.cpp, line 102 https://git.reviewboard.kde.org/r/116787/diff/5/?file=254570#file254570line102 Is this compensated anywhere? Is it actually an issue (since the constructor should operate in the GUI

Re: Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

2014-03-19 Thread Martin Gräßlin
On March 17, 2014, 9:33 p.m., Thomas Lübking wrote: src/kwindowsystem_x11.cpp, line 102 https://git.reviewboard.kde.org/r/116787/diff/5/?file=254570#file254570line102 Is this compensated anywhere? Is it actually an issue (since the constructor should operate in the GUI

Re: Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

2014-03-19 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116787/ --- (Updated March 19, 2014, 3:40 p.m.) Status -- This change has been

Re: Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

2014-03-17 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116787/ --- (Updated March 17, 2014, 9 a.m.) Review request for KDE Frameworks, kwin

Re: Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

2014-03-17 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116787/ --- (Updated March 17, 2014, 9:04 a.m.) Review request for KDE Frameworks,

Re: Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

2014-03-17 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116787/ --- (Updated March 17, 2014, 9:09 a.m.) Review request for KDE Frameworks,

Re: Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

2014-03-15 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116787/#review52957 --- looks good to me, just a few minor nitpicks. Most is: prefer

Re: Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

2014-03-14 Thread Aaron J. Seigo
On March 13, 2014, 10:31 p.m., Martin Gräßlin wrote: did you try to make it not use QWidget anymore? There shouldn't be a reason why it is QWidget. No; I can try it as a non QWidget ... let's see how that goes. - Aaron J. ---

Re: Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

2014-03-14 Thread Aaron J. Seigo
On March 13, 2014, 10:31 p.m., Martin Gräßlin wrote: did you try to make it not use QWidget anymore? There shouldn't be a reason why it is QWidget. Aaron J. Seigo wrote: No; I can try it as a non QWidget ... let's see how that goes. So, challenges a plenty :) First, this line in

Re: Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

2014-03-14 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116787/ --- (Updated March 14, 2014, 10:36 a.m.) Review request for KDE Frameworks,

Re: Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

2014-03-14 Thread Thomas Lübking
On March 13, 2014, 10:40 p.m., Thomas Lübking wrote: You'll need a drawable, clients will require XInitThreads if that is accessed from a different than the GUI thread, but it might be possible to use an internal Window and move the QObject to the GUI thread on construction.

Re: Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

2014-03-14 Thread Martin Gräßlin
On March 13, 2014, 11:40 p.m., Thomas Lübking wrote: You'll need a drawable, clients will require XInitThreads if that is accessed from a different than the GUI thread, but it might be possible to use an internal Window and move the QObject to the GUI thread on construction.

Re: Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

2014-03-14 Thread Thomas Lübking
On March 13, 2014, 10:40 p.m., Thomas Lübking wrote: You'll need a drawable, clients will require XInitThreads if that is accessed from a different than the GUI thread, but it might be possible to use an internal Window and move the QObject to the GUI thread on construction.

Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

2014-03-13 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116787/ --- Review request for KDE Frameworks, kwin and Martin Gräßlin. Repository:

Re: Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

2014-03-13 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116787/#review52915 --- You'll need a drawable, clients will require XInitThreads if