Re: Review Request 117148: use renamed kf5_entry.desktop file

2014-05-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117148/#review57058 --- This review has been submitted with commit

Re: Review Request 117148: use renamed kf5_entry.desktop file

2014-05-01 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117148/ --- (Updated May 1, 2014, 1:29 p.m.) Status -- This change has been

Re: Review Request 117148: use renamed kf5_entry.desktop file

2014-04-30 Thread David Faure
On April 29, 2014, 9:22 a.m., Jonathan Riddell wrote: I disagree, ./src/kdecore/entry.desktop gets renamed to kf5_entry.desktop on install and installs into /usr/share/locale/en_US/kf5_entry.desktop so it is the locale entry.desktop file which has been renamed not the country

Re: Review Request 117148: use renamed kf5_entry.desktop file

2014-04-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117148/#review57006 --- Shouldn't we port this to

Re: Review Request 117148: use renamed kf5_entry.desktop file

2014-04-30 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117148/ --- (Updated April 30, 2014, 3:38 p.m.) Review request for KDE Frameworks,

Re: Review Request 117148: use renamed kf5_entry.desktop file

2014-04-30 Thread David Faure
On April 29, 2014, 9:22 a.m., Jonathan Riddell wrote: I disagree, ./src/kdecore/entry.desktop gets renamed to kf5_entry.desktop on install and installs into /usr/share/locale/en_US/kf5_entry.desktop so it is the locale entry.desktop file which has been renamed not the country

Re: Review Request 117148: use renamed kf5_entry.desktop file

2014-04-29 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117148/#review56831 --- I disagree, ./src/kdecore/entry.desktop gets renamed to

Re: Review Request 117148: use renamed kf5_entry.desktop file

2014-04-29 Thread Jonathan Riddell
On April 29, 2014, 9:22 a.m., Jonathan Riddell wrote: I disagree, ./src/kdecore/entry.desktop gets renamed to kf5_entry.desktop on install and installs into /usr/share/locale/en_US/kf5_entry.desktop so it is the locale entry.desktop file which has been renamed not the country

Re: Review Request 117148: use renamed kf5_entry.desktop file

2014-04-29 Thread Aleix Pol Gonzalez
On April 29, 2014, 9:22 a.m., Jonathan Riddell wrote: I disagree, ./src/kdecore/entry.desktop gets renamed to kf5_entry.desktop on install and installs into /usr/share/locale/en_US/kf5_entry.desktop so it is the locale entry.desktop file which has been renamed not the country

Re: Review Request 117148: use renamed kf5_entry.desktop file

2014-04-29 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117148/ --- (Updated April 29, 2014, 11:10 a.m.) Review request for KDE Frameworks,

Re: Review Request 117148: use renamed kf5_entry.desktop file

2014-04-29 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117148/#review56863 --- And now that I see it, kconfigwidgets can't be relying on a

Re: Review Request 117148: use renamed kf5_entry.desktop file

2014-03-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117148/#review54526 --- No, no. This is a language entry.desktop file, not a country